Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #update_application #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RoxasShadow
Copy link

Hello!

I had the need to update a candidate's application but I couldn't any way to do that currently as Client#applications is a GET-only method, and this is why I implemented a new specialized method called Client#update_application.

I couldn't find instructions for VCR conventions. What I did was to use my sandbox account to create them and replace the token with the fake token currently used by the other cassettes, but I'm not sure if you prefer the IDs being faked or not.

"This usage of the Code Climate Test Reporter is now deprecated. Since version
1.0, we now require you to run `SimpleCov` in your test/spec helper, and then
run the provided `codeclimate-test-reporter` binary separately to report your
results to Code Climate.
More information here: https://github.com/codeclimate/ruby-test-reporter/blob/master/README.md"
@RoxasShadow
Copy link
Author

RoxasShadow commented Jul 31, 2017

To make tests pass for ruby19 I think we should lock the rake gem in the gemspec file to an older version, but I'm not sure what's your idea about supporting versions older than ruby2 (in case there's an agreement on dropping the support for ruby19, I think that upgrading all the other gems greenhouse_io depends on would also be a good idea).

@atrzaska atrzaska deleted the patch-application branch August 5, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant