New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add weather forecast #1944

Merged

bim9262 merged 1 commit into greshake:master from bim9262:forecast

Oct 6, 2023

Collaborator

bim9262 commented Sep 5, 2023

Fixes #1267

bim9262 commented

View reviewed changes

src/blocks/weather.rs Outdated Show resolved Hide resolved

src/blocks/weather.rs Outdated Show resolved Hide resolved

src/blocks/weather/open_weather_map.rs Show resolved Hide resolved

bim9262 force-pushed the forecast branch from 3d3a49d to fd946a0 Compare

September 5, 2023 03:35

This comment was marked as resolved.

Sign in to view

MaxVerevkin reviewed

View reviewed changes

src/blocks/weather.rs Outdated Show resolved Hide resolved

Collaborator

MaxVerevkin commented Sep 5, 2023

omit the keys from the map entirely.

This is probably the best option, as users will be able to customize the output to their liking. It just needs to be documented very explicitly.

MaxVerevkin reviewed

View reviewed changes

src/blocks/weather.rs Outdated Show resolved Hide resolved

MaxVerevkin reviewed

View reviewed changes

src/blocks/weather.rs Outdated Show resolved Hide resolved

bim9262 commented

View reviewed changes

src/blocks/weather.rs Outdated Show resolved Hide resolved

MaxVerevkin reviewed

View reviewed changes

src/blocks/weather/met_no.rs Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

bim9262 force-pushed the forecast branch from 855ac5e to f8376fe Compare

September 11, 2023 23:50

MaxVerevkin reviewed

View reviewed changes

src/blocks/weather.rs Outdated Show resolved Hide resolved

bim9262 force-pushed the forecast branch from f8376fe to db44080 Compare

September 12, 2023 23:15

MaxVerevkin reviewed

View reviewed changes

src/blocks/weather.rs Outdated Show resolved Hide resolved

MaxVerevkin reviewed

View reviewed changes

src/blocks/weather.rs Outdated Show resolved Hide resolved

bim9262 force-pushed the forecast branch from db44080 to 60f3487 Compare

September 13, 2023 19:13

MaxVerevkin reviewed

View reviewed changes

src/blocks/weather.rs Outdated Show resolved Hide resolved

bim9262 force-pushed the forecast branch 2 times, most recently from 714448e to a276d9a Compare

September 21, 2023 04:57

bim9262 force-pushed the forecast branch 3 times, most recently from cc505ea to 6de9953 Compare

October 6, 2023 06:30

MaxVerevkin reviewed

View reviewed changes

src/blocks/weather.rs Outdated Show resolved Hide resolved


          Add weather forecast

4bc1663

Only include forecast if needed

Forecasts are only fetched if forecast_hours > 0 and the format has keys
related to forecast

bim9262 force-pushed the forecast branch from 6de9953 to 4bc1663 Compare

October 6, 2023 13:58

MaxVerevkin approved these changes

View reviewed changes

Collaborator

MaxVerevkin left a comment

Looks good.

Thanks for working on this!

Collaborator Author

bim9262 commented Oct 6, 2023

Thanks @MaxVerevkin!

bim9262 merged commit 205bfeb into greshake:master

11 checks passed

bim9262 deleted the forecast branch

October 6, 2023 17:18

bim9262 mentioned this pull request

Weather forecast #1663

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet