Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode full name and hint with UTF-8 #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

choules
Copy link

@choules choules commented Jun 28, 2021

We had problems with German umlauts with user's full names when creating accounts using pycreateuserpkg. The changes made here have solved the problem for us and may be helpful for other users as well.

Since I have no real experience with UTF-8 support in Python 2.7 this may not be the ideal solution...

@gregneagle
Copy link
Owner

This looks like the right solution for Python2 at least. I want to test under Python3 as well. Could you provide some sample input that triggers the problem? I suppose a name like "Schröder" would do it?

(I only ever imagined this tool being used to create local admin or utility accounts and not for general-purpose user accounts, so I'm sure there are more issues lurking. What if people use umlauts and other non-ASCII characters in the password, or short name, or....)

@choules
Copy link
Author

choules commented Jun 28, 2021

In our case the user's full name was "Benutzer für Präsentationen", so a generic account for presentation purposes. The change would be required at least for the password, as well – but this was not necessary for our use case.

@choules
Copy link
Author

choules commented Jun 28, 2021

I have tested it with the character "ß" in the full name and hint fields, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants