Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrap-async-body 안에서도 csk 변환 #91

Merged
merged 1 commit into from
Jan 9, 2023
Merged

wrap-async-body 안에서도 csk 변환 #91

merged 1 commit into from
Jan 9, 2023

Conversation

neverlish
Copy link

@neverlish neverlish commented Jan 9, 2023 •
edited
Loading

사유

작업

yyna
yyna reviewed Jan 9, 2023
View reviewed changes
src/gosura/helpers/resolver2.clj
Comment on lines -82 to -83
(cond-> ~result
~return-camel-case? (update-resolver-result transform-keys->camelCaseKeyword)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 케이스 변환이 안되나요?

Copy link
Author

@neverlish neverlish Jan 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 안되었어요. async? 옵션이 있는 경우, ~result 의 결과물이 body 가 아니라 쓰레드풀이라 그런 것으로 저는 파악했어요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

promise라서 그런 것 같아요.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 브랜치로의 PR이라서 머지하고 테스트 및 테스트 코드 작성해보겠습니다.

@jungwookim
Copy link
Contributor

감사합니다!

@jungwookim jungwookim merged commit dd6a235 into defresolver-async-option Jan 9, 2023
@jungwookim jungwookim deleted the defresolver-async-option-csk branch January 9, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyna yyna yyna left review comments

@jungwookim jungwookim jungwookim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neverlish @jungwookim @yyna