Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(supported-version): add all kind #36

Merged
merged 4 commits into from
Aug 12, 2022
Merged

feat(supported-version): add all kind #36

merged 4 commits into from
Aug 12, 2022

Conversation

damienwebdev
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

I wasn't confident that the code I have in place for #35 actually supports every version out there.

Fixes: N/A

What is the new behavior?

As such, I've added a new kind to trial against ALL Magento versions.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Collaborator

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question - why do we need the supported-version/dist/index.js file?

@damienwebdev
Copy link
Member Author

@ihor-sviziev I prefer writing in typescript, and Github's recommendation is to build to js and commit. see: https://github.com/actions/typescript-action

@ihor-sviziev
Copy link
Collaborator

Sorry, my question was about supported-version/src/kind/all.json

@damienwebdev
Copy link
Member Author

@ihor-sviziev that was a miss on my part.

@damienwebdev
Copy link
Member Author

damienwebdev commented Aug 12, 2022

The underlying bugs here are results of issues between the @mage-os mirror and upstream Magento.

The mirror is building from tags in the repo, whereas mainline Magento has packages tagged as one version, but published as another.

The offending package appears to be the Adobe Stock Integration. See: magento/adobe-stock-integration#1872

See also: magento/adobe-stock-integration#1873

@damienwebdev damienwebdev merged commit 26c354d into main Aug 12, 2022
@damienwebdev damienwebdev deleted the add_all_kind branch August 12, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants