Fix flaky TestSSHHeadless #47732
Open
Fix flaky TestSSHHeadless #47732
+37
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
backport/branch/v14
no-changelog
rosstimothy
added a commit
that referenced
this pull request
Oct 19, 2024
Makes the same changes as #47732 to address issues that TestHeadlessDoesNotAddKeysToAgent has in common with TestSSHHeadless.
|
Flaky Test Detector looks to be tripped by the slowness of the test. Locally the test takes ~12s. I don't know that there is much room for improvement here given that the test, and it's subtests cannot be made parallel due to the use of |
github-actions
bot
added
size/sm
tsh
avatus
approved these changes
Oct 19, 2024
zmb3
approved these changes
Oct 19, 2024
public-teleport-github-review-bot
bot
removed the request for review
from atburke
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39562