feat: support origin label when creating a new aws oidc integration #47725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyinghermit
added
the
no-changelog
flyinghermit
commented
Oct 18, 2024
| // OriginAWSIdentityCenter indicates that the resource was | ||
| // imported from the AWS Identity Center or belongs to the | ||
| // Teleort Identity Center integration. | ||
| OriginAWSIdentityCenter = "aws-identity-center" |
There was a problem hiding this comment.
@tcsc FYI, I added this origin label with aws-identity-center here. In the poc work, we used aws_iam_ic. Is there any preference for you? My reason for picking up aws-identity-center is that is used in the Plugin related work but should not hamper if this is different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
aws-identity-center. It will be used to reference resources imported from AWS identity center and also group identity center related resources in Teleport so they can be prevented from update/deletion while the identity center plugin is still active.-updates Web UI:
originvalue in Web UI integration create request.The goal is to tie oidc integration (address in this PR), saml service provider together with the Identity Center plugin so that these dependency can be prevented from update/deletion without editing/deleting the plugin itself. Such prevention will be followed up separately once the other plugin related work is merged to master.
Only applies to AWS OIDC integration create method. Other integration types and integration update method is left unchanged.
Part of https://github.com/gravitational/teleport.e/issues/4839