Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAutoEnroll_disabledByEnv flakiness #47723

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

codingllama
Copy link
Contributor

@codingllama codingllama commented Oct 18, 2024

Fix flakiness introduced by #47679.

Co-authored-by: rosstimothy <[email protected]>
@codingllama codingllama added this pull request to the merge queue Oct 18, 2024
Merged via the queue into master with commit 335cae0 Oct 18, 2024
38 checks passed
@codingllama codingllama deleted the codingllama/autoenroll-flake branch October 18, 2024 19:18
@public-teleport-github-review-bot

@codingllama See the table below for backport results.

Branch Result
branch/v16 Failed

codingllama added a commit that referenced this pull request Oct 18, 2024
* Fix TestAutoEnroll_disabledByEnv flakiness

* Use t.Setenv

Co-authored-by: rosstimothy <[email protected]>

---------

Co-authored-by: rosstimothy <[email protected]>
codingllama added a commit that referenced this pull request Oct 18, 2024
* Fix TestAutoEnroll_disabledByEnv flakiness

* Use t.Setenv

Co-authored-by: rosstimothy <[email protected]>

---------

Co-authored-by: rosstimothy <[email protected]>
codingllama added a commit that referenced this pull request Oct 18, 2024
* Fix TestAutoEnroll_disabledByEnv flakiness

* Use t.Setenv

Co-authored-by: rosstimothy <[email protected]>

---------

Co-authored-by: rosstimothy <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 18, 2024
* feat: Disable auto-enroll via environment variable

* Fix TestAutoEnroll_disabledByEnv flakiness (#47723)

* Fix TestAutoEnroll_disabledByEnv flakiness

* Use t.Setenv

Co-authored-by: rosstimothy <[email protected]>

---------

Co-authored-by: rosstimothy <[email protected]>

---------

Co-authored-by: rosstimothy <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 18, 2024
* feat: Disable auto-enroll via environment variable

* Fix TestAutoEnroll_disabledByEnv flakiness (#47723)

* Fix TestAutoEnroll_disabledByEnv flakiness

* Use t.Setenv

Co-authored-by: rosstimothy <[email protected]>

---------

Co-authored-by: rosstimothy <[email protected]>

---------

Co-authored-by: rosstimothy <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 18, 2024
* feat: Disable auto-enroll via environment variable

* Fix TestAutoEnroll_disabledByEnv flakiness (#47723)

* Fix TestAutoEnroll_disabledByEnv flakiness

* Use t.Setenv

Co-authored-by: rosstimothy <[email protected]>

---------

Co-authored-by: rosstimothy <[email protected]>

---------

Co-authored-by: rosstimothy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants