-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TestAutoEnroll_disabledByEnv flakiness #47723
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
added
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v16
labels
Oct 18, 2024
ryanclark
approved these changes
Oct 18, 2024
rosstimothy
reviewed
Oct 18, 2024
Co-authored-by: rosstimothy <[email protected]>
codingllama
force-pushed
the
codingllama/autoenroll-flake
branch
from
October 18, 2024 18:42
a0ebac7
to
fe06391
Compare
rosstimothy
approved these changes
Oct 18, 2024
public-teleport-github-review-bot
bot
removed request for
gabrielcorado and
zmb3
October 18, 2024 18:45
@codingllama See the table below for backport results.
|
codingllama
added a commit
that referenced
this pull request
Oct 18, 2024
* Fix TestAutoEnroll_disabledByEnv flakiness * Use t.Setenv Co-authored-by: rosstimothy <[email protected]> --------- Co-authored-by: rosstimothy <[email protected]>
codingllama
added a commit
that referenced
this pull request
Oct 18, 2024
* Fix TestAutoEnroll_disabledByEnv flakiness * Use t.Setenv Co-authored-by: rosstimothy <[email protected]> --------- Co-authored-by: rosstimothy <[email protected]>
codingllama
added a commit
that referenced
this pull request
Oct 18, 2024
* Fix TestAutoEnroll_disabledByEnv flakiness * Use t.Setenv Co-authored-by: rosstimothy <[email protected]> --------- Co-authored-by: rosstimothy <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* feat: Disable auto-enroll via environment variable * Fix TestAutoEnroll_disabledByEnv flakiness (#47723) * Fix TestAutoEnroll_disabledByEnv flakiness * Use t.Setenv Co-authored-by: rosstimothy <[email protected]> --------- Co-authored-by: rosstimothy <[email protected]> --------- Co-authored-by: rosstimothy <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* feat: Disable auto-enroll via environment variable * Fix TestAutoEnroll_disabledByEnv flakiness (#47723) * Fix TestAutoEnroll_disabledByEnv flakiness * Use t.Setenv Co-authored-by: rosstimothy <[email protected]> --------- Co-authored-by: rosstimothy <[email protected]> --------- Co-authored-by: rosstimothy <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* feat: Disable auto-enroll via environment variable * Fix TestAutoEnroll_disabledByEnv flakiness (#47723) * Fix TestAutoEnroll_disabledByEnv flakiness * Use t.Setenv Co-authored-by: rosstimothy <[email protected]> --------- Co-authored-by: rosstimothy <[email protected]> --------- Co-authored-by: rosstimothy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flakiness introduced by #47679.