Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support datadog plugin helm chart #47075

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Support datadog plugin helm chart #47075

merged 6 commits into from
Oct 18, 2024

Conversation

bernardjkim
Copy link
Contributor

This PR adds support for the Datadog Incident Management plugin helm chart.

changelog: Add support for the Datadog Incident Management plugin helm chart.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

🤖 Vercel preview here: https://docs-36eoe8qcc-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-q3q8fqf2n-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-2qx2bs1n6-goteleport.vercel.app/docs/ver/preview

@bernardjkim bernardjkim marked this pull request as ready for review October 17, 2024 01:10
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-gugx0jffo-goteleport.vercel.app/docs/ver/preview

r0mant
r0mant approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I'd get @hugoShaka's checkmark as well

hugoShaka
hugoShaka approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@hugoShaka hugoShaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If you want to walk the extra mile and improve the chart UX, the slack Helm chart has a native tbot integration that would be nice to have here. The diff looks like this https://github.com/gravitational/teleport/pull/46353/files and allows users to not have to deal with Teleport identities and connect with minimal values:

datadog:
  apiKey: abc
  applicationKey: def
  fallbackRecipient: [email protected]

tbot:
  enabled: true
  clusterName: example.teleport.sh
  teleportProxyAddress: example.teleport.sh:443
  joinMethod: token
  token: <INSERT TOKEN HERE>

examples/chart/access/datadog/README.md Show resolved Hide resolved
examples/chart/access/datadog/values.yaml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-pynxghp2z-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-pgwll5r8w-goteleport.vercel.app/docs/ver/preview

hugoShaka
hugoShaka approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@hugoShaka hugoShaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the tbot integration :)

@hugoShaka
Copy link
Contributor

Should this be backported to v16?

@bernardjkim
Copy link
Contributor Author

Yeah, we'll want to backport to v16.

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-mzyb8utdk-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-iogbdrkaa-goteleport.vercel.app/docs/ver/preview

@bernardjkim bernardjkim added this pull request to the merge queue Oct 18, 2024
Merged via the queue into master with commit 4b008ce Oct 18, 2024
40 checks passed
@bernardjkim bernardjkim deleted the bernard/datadog-helm branch October 18, 2024 21:43
@public-teleport-github-review-bot
Copy link

@bernardjkim See the table below for backport results.

Branch Result
branch/v16 Create PR

@bernardjkim bernardjkim mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0mant r0mant r0mant approved these changes

@hugoShaka hugoShaka hugoShaka approved these changes

Assignees
No one assigned
Labels
backport/branch/v16 documentation helm size/lg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bernardjkim @hugoShaka @r0mant