Enable StatusString for all readers #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
In #37, a
readerOpt
was added as an option to enableStatusString
to workaround UT issues. However, this means the default connection pool does NOT have this flag ENABLED, thus making the originalStatusString
fix USELESS. 😭This PR reverted the
readerOpt
part and fixed the other UTs properly.I did consider pushing the
StatusString
fix upstream but it's clear that this breaks backward compatibility ascmd.Val()
will return aproto.StatusString
instead ofstring
.Will need to revisit later to see if possible to make an upstream acceptable version of the fix or maybe fix this entirely on the Teleport side without driver change.
Also there are some testing escapes. Will add a "COMMAND DOCS" test at a higher level in teleport repo. And for e2e testing, we should always test out a user with full permission (I didn't catch this because my users do not have
COMMAND DOCS
permission to trigger this case)