Select return content type based on Accept header #919

Shane32 · 2022-08-26T23:58:11Z

No description provided.

Shane32 · 2022-08-28T16:55:09Z

@sungam3r It seems that there may be many applications which require application/json as the content-type rather than application/graphql-response+json. As such, I'm considering this a critical bug and will be releasing 7.1 with this fix shortly if you have no comments. I would really appreciate comments on the implementation - see issue #917 .

jeffw-wherethebitsroam · 2022-08-29T07:24:46Z

src/Transports.AspNetCore/GraphQLHttpMiddleware.cs

+            }
+        }
+
+        return CONTENTTYPE_GRAPHQLRESPONSEJSON;


The problem here is that if you only have a single misbehaving client, then you would need to subclass the GraphQLHttpMiddleware and recreate the logic above with a different fall-back. It would still be really good to be able to just override the default response content type.

src/Transports.AspNetCore/GraphQLHttpMiddleware.cs

+                if (mediaType.Suffix.HasValue)
+                {
+                    return MatchesSubtypeWithoutSuffix(mediaType, set) && MatchesSubtypeSuffix(mediaType, set);
+                }
+                else
+                {
+                    return false;
+                }


src/Transports.AspNetCore/GraphQLHttpMiddleware.cs

+            foreach (var acceptHeader in acceptHeaders.OrderBy(x => x.MatchesAllTypes ? 4 : x.MatchesAllSubTypes ? 3 : x.MatchesAllSubTypesWithoutSuffix ? 2 : 1))
+            {
+                var response = CheckForMatch(acceptHeader);
+                if (response != null)
+                    return response;
+            }


codecov-commenter · 2022-09-02T15:36:01Z

Codecov Report

Merging #919 (e01c2fa) into master (d80414d) will decrease coverage by 0.08%.
The diff coverage is 93.47%.

@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
- Coverage   95.18%   95.09%   -0.09%     
==========================================
  Files          42       42              
  Lines        1992     2078      +86     
  Branches      336      358      +22     
==========================================
+ Hits         1896     1976      +80     
- Misses         55       59       +4     
- Partials       41       43       +2

Impacted Files	Coverage Δ
src/Transports.AspNetCore/GraphQLHttpMiddleware.cs	`95.13% <93.40%> (-0.50%)`	⬇️
...nsports.AspNetCore/GraphQLHttpMiddlewareOptions.cs	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Shane32 · 2022-09-02T15:43:38Z

@jeffw-wherethebitsroam Want to review these changes for me? I think I have the logic figured out, but just wondering if perhaps the MediaTypeHeaderValue type would be better than string for the option, considering the comparison logic now included here.

@sungam3r I would appreciate your comments, but have not heard from you in the last week. I will wait another 24 hours for a review before merging these changes and releasing 7.1. Thanks!

General logic this PR now has:

Loops through each media type listed in the Accept header
Prioritizes so that specific media types are given priority, whereas wildcard media types are given the least priority
For each type listed:
a. Checks if it matches the default content type. Includes matching on charset. So a request of application/json will match on a default content type of application/json; charset=utf-8.
b. Checks if it matches application/graphql+response+json; charset=utf-8.
c. Checks if it matches application/json; charset=utf-8.
d. Checks if it matches the deprecated application/graphql+json; charset=utf-8.
The first match found is returned; if no matches are found, the default content type is returned.

This means that by default, these responses are given:

Accept request header	Content-Type response header
(none)	`application/graphql-response+json; charset=utf-8`
`/`	`application/graphql-response+json; charset=utf-8`
`application/*`	`application/graphql-response+json; charset=utf-8`
`application/*+json`	`application/graphql-response+json; charset=utf-8`
`application/graphql-response+json`	`application/graphql-response+json; charset=utf-8`
`application/graphql+json`	`application/graphql+json; charset=utf-8`
`application/json`	`application/json; charset=utf-8`
`/, application/json`	`application/json; charset=utf-8`

By changing the default to application/json, the prior default, then you get these results:

Accept request header	Content-Type response header
(none)	`application/json`
`/`	`application/json`
`application/*`	`application/json`
`application/*+json`	`application/graphql-response+json; charset=utf-8`
`application/graphql-response+json`	`application/graphql-response+json; charset=utf-8`
`application/graphql+json`	`application/graphql+json; charset=utf-8`
`application/json`	`application/json`
`/, application/json`	`application/json`

Since 7.0 is only a couple weeks old, the migration document was modified to reflect changes from 6.x to 7.1.

tests/ApiApprovalTests/net5+netcoreapp31/GraphQL.Server.Transports.AspNetCore.approved.txt

jeffw-wherethebitsroam · 2022-09-05T07:17:58Z

Hi @Shane32. Busy weekend, so didn't get a chance to look before now, but it looks good to me.

bithavoc · 2022-09-13T13:45:35Z

Thanks so much, this fixed an issue while trying to consume from graphql-request where it always expects application/json

sungam3r · 2022-09-19T18:05:26Z

tests/Transports.AspNetCore.Tests/Middleware/GetTests.cs

+    [Theory]
+    [InlineData(null, "application/graphql+json", "application/graphql+json; charset=utf-8")]
+    [InlineData(null, "application/json", "application/json; charset=utf-8")]
+    [InlineData(null, "application/json; charset=utf-8", "application/json; charset=utf-8")]
+    [InlineData(null, "application/json; charset=UTF-8", "application/json; charset=utf-8")]
+    [InlineData(null, "APPLICATION/JSON", "application/json; charset=utf-8")]
+    [InlineData(null, "APPLICATION/JSON; CHARSET=\"UTF-8\" ", "application/json; charset=utf-8")]
+    [InlineData(null, "*/*; CHARSET=\"UTF-8\" ", "application/graphql-response+json; charset=utf-8")]
+    [InlineData(null, "application/*; charset=utf-8", "application/graphql-response+json; charset=utf-8")]
+    [InlineData(null, "application/*+json; charset=utf-8", "application/graphql-response+json; charset=utf-8")]
+    [InlineData(null, "application/pdf", "application/graphql-response+json; charset=utf-8")]
+    [InlineData(null, "application/json; charset=utf-7", "application/graphql-response+json; charset=utf-8")]
+    [InlineData("application/graphql-response+json; charset=utf-8", "application/graphql+json", "application/graphql+json; charset=utf-8")]
+    [InlineData("application/graphql-response+json; charset=utf-8", "application/json", "application/json; charset=utf-8")]
+    [InlineData("application/graphql-response+json; charset=utf-8", "application/json; charset=utf-8", "application/json; charset=utf-8")]
+    [InlineData("application/graphql-response+json; charset=utf-8", "application/json; charset=UTF-8", "application/json; charset=utf-8")]
+    [InlineData("application/graphql-response+json; charset=utf-8", "APPLICATION/JSON", "application/json; charset=utf-8")]
+    [InlineData("application/graphql-response+json; charset=utf-8", "APPLICATION/JSON; CHARSET=\"UTF-8\" ", "application/json; charset=utf-8")]
+    [InlineData("application/graphql-response+json; charset=utf-8", "*/*; CHARSET=\"UTF-8\" ", "application/graphql-response+json; charset=utf-8")]
+    [InlineData("application/graphql-response+json; charset=utf-8", "application/*; charset=utf-8", "application/graphql-response+json; charset=utf-8")]
+    [InlineData("application/graphql-response+json; charset=utf-8", "application/*+json; charset=utf-8", "application/graphql-response+json; charset=utf-8")]
+    [InlineData("application/graphql-response+json; charset=utf-8", "application/pdf", "application/graphql-response+json; charset=utf-8")]
+    [InlineData("application/graphql-response+json; charset=utf-8", "application/json; charset=utf-7", "application/graphql-response+json; charset=utf-8")]
+    [InlineData("application/graphql+json; charset=utf-8", "application/graphql+json", "application/graphql+json; charset=utf-8")]
+    [InlineData("application/graphql+json; charset=utf-8", "application/json", "application/json; charset=utf-8")]
+    [InlineData("application/graphql+json; charset=utf-8", "application/json; charset=utf-8", "application/json; charset=utf-8")]
+    [InlineData("application/graphql+json; charset=utf-8", "application/json; charset=UTF-8", "application/json; charset=utf-8")]
+    [InlineData("application/graphql+json; charset=utf-8", "APPLICATION/JSON", "application/json; charset=utf-8")]
+    [InlineData("application/graphql+json; charset=utf-8", "APPLICATION/JSON; CHARSET=\"UTF-8\" ", "application/json; charset=utf-8")]
+    [InlineData("application/graphql+json; charset=utf-8", "*/*; CHARSET=\"UTF-8\" ", "application/graphql+json; charset=utf-8")]
+    [InlineData("application/graphql+json; charset=utf-8", "application/*; charset=utf-8", "application/graphql+json; charset=utf-8")]
+    [InlineData("application/graphql+json; charset=utf-8", "application/*+json; charset=utf-8", "application/graphql+json; charset=utf-8")]
+    [InlineData("application/graphql+json; charset=utf-8", "application/pdf", "application/graphql+json; charset=utf-8")]
+    [InlineData("application/graphql+json; charset=utf-8", "application/json; charset=utf-7", "application/graphql+json; charset=utf-8")]
+    [InlineData("application/json; charset=utf-8", "application/graphql+json", "application/graphql+json; charset=utf-8")]
+    [InlineData("application/json; charset=utf-8", "application/json", "application/json; charset=utf-8")]
+    [InlineData("application/json; charset=utf-8", "application/json; charset=utf-8", "application/json; charset=utf-8")]
+    [InlineData("application/json; charset=utf-8", "application/json; charset=UTF-8", "application/json; charset=utf-8")]
+    [InlineData("application/json; charset=utf-8", "APPLICATION/JSON", "application/json; charset=utf-8")]
+    [InlineData("application/json; charset=utf-8", "APPLICATION/JSON; CHARSET=\"UTF-8\" ", "application/json; charset=utf-8")]
+    [InlineData("application/json; charset=utf-8", "*/*; CHARSET=\"UTF-8\" ", "application/json; charset=utf-8")]
+    [InlineData("application/json; charset=utf-8", "application/*; charset=utf-8", "application/json; charset=utf-8")]
+    [InlineData("application/json; charset=utf-8", "application/*+json; charset=utf-8", "application/graphql-response+json; charset=utf-8")]
+    [InlineData("application/json; charset=utf-8", "application/pdf", "application/json; charset=utf-8")]
+    [InlineData("application/json; charset=utf-8", "application/json; charset=utf-7", "application/json; charset=utf-8")]
+    [InlineData("application/json", "application/graphql+json", "application/graphql+json; charset=utf-8")]
+    [InlineData("application/json", "application/json", "application/json")]
+    [InlineData("application/json", "application/json; charset=utf-8", "application/json; charset=utf-8")]
+    [InlineData("application/json", "application/json; charset=UTF-8", "application/json; charset=utf-8")]
+    [InlineData("application/json", "APPLICATION/JSON", "application/json")]
+    [InlineData("application/json", "APPLICATION/JSON; CHARSET=\"UTF-8\" ", "application/json; charset=utf-8")]
+    [InlineData("application/json", "*/*; CHARSET=\"UTF-8\" ", "application/json; charset=utf-8")]
+    [InlineData("application/json", "application/*; charset=utf-8", "application/json; charset=utf-8")]
+    [InlineData("application/json", "application/*+json; charset=utf-8", "application/graphql-response+json; charset=utf-8")]
+    [InlineData("application/json", "application/pdf", "application/json")]
+    [InlineData("application/json", "application/json; charset=utf-7", "application/json")]
+    [InlineData(null, "*/*, application/graphql-response+json", "application/graphql-response+json; charset=utf-8")]
+    [InlineData(null, "*/*, application/graphql+json", "application/graphql+json; charset=utf-8")]
+    [InlineData(null, "*/*, application/json", "application/json; charset=utf-8")]
+    [InlineData(null, "*/*, application/pdf", "application/graphql-response+json; charset=utf-8")]
+    [InlineData(null, "application/*, application/graphql-response+json", "application/graphql-response+json; charset=utf-8")]
+    [InlineData(null, "application/*, application/graphql+json", "application/graphql+json; charset=utf-8")]
+    [InlineData(null, "application/*, application/json", "application/json; charset=utf-8")]
+    [InlineData(null, "application/*, application/pdf", "application/graphql-response+json; charset=utf-8")]
+    [InlineData(null, "application/*+json, application/graphql-response+json", "application/graphql-response+json; charset=utf-8")]
+    [InlineData(null, "application/*+json, application/graphql+json", "application/graphql+json; charset=utf-8")]
+    [InlineData(null, "application/*+json, application/json", "application/json; charset=utf-8")]
+    [InlineData(null, "application/*+json, application/pdf", "application/graphql-response+json; charset=utf-8")]
+    [InlineData(null, "application/graphql+json, application/json", "application/graphql+json; charset=utf-8")]
+    [InlineData("application/json", "*/*, application/graphql-response+json", "application/graphql-response+json; charset=utf-8")]
+    [InlineData("application/json", "*/*, application/graphql+json", "application/graphql+json; charset=utf-8")]
+    [InlineData("application/json", "*/*, application/json", "application/json")]
+    [InlineData("application/json", "*/*, application/pdf", "application/json")]
+    [InlineData("application/json", "application/*, application/graphql-response+json", "application/graphql-response+json; charset=utf-8")]
+    [InlineData("application/json", "application/*, application/graphql+json", "application/graphql+json; charset=utf-8")]
+    [InlineData("application/json", "application/*, application/json", "application/json")]
+    [InlineData("application/json", "application/*, application/pdf", "application/json")]
+    [InlineData("application/json", "application/*+json, application/graphql-response+json", "application/graphql-response+json; charset=utf-8")]
+    [InlineData("application/json", "application/*+json, application/graphql+json", "application/graphql+json; charset=utf-8")]
+    [InlineData("application/json", "application/*+json, application/json", "application/json")]
+    [InlineData("application/json", "application/*+json, application/pdf", "application/graphql-response+json; charset=utf-8")]
+    [InlineData("application/json", "application/graphql+json, application/json", "application/graphql+json; charset=utf-8")]
+    public async Task AcceptHeaderHonored(string? defaultMediaType, string mediaType, string expected)


You know I like my [Theory]s...

sungam3r · 2022-09-19T18:12:16Z

tests/Transports.AspNetCore.Tests/Middleware/GetTests.cs

+    [InlineData(null, "application/*+json, application/graphql-response+json", "application/graphql-response+json; charset=utf-8")]
+    [InlineData(null, "application/*+json, application/graphql+json", "application/graphql+json; charset=utf-8")]
+    [InlineData(null, "application/*+json, application/json", "application/json; charset=utf-8")]
+    [InlineData(null, "application/*+json, application/pdf", "application/graphql-response+json; charset=utf-8")]


I think thre should be test for "application/pdf" accept header when server returns error. From https://datatracker.ietf.org/doc/html/rfc7231#section-5.3.2:

According to the draft spec (as of today; it's a moving target!):

In alignment with the HTTP 1.1 Accept specification, when a client does not include at least one supported media type in the Accept HTTP header, the server MUST either:

Disregard the Accept header and respond with the default media type of application/json, specifying this in the Content-Type header; OR

Respond with a 406 Not Acceptable status code and stop processing the request.

I elected the first option. I would agree that the latter would be better, but I was thinking this change would come in 8.0, as it would involve processing the header earlier in the flow and so would change the design of the middleware.

We could also support additional character encodings; we do so for requests -- why not responses also? I have no urgency to do so; you're the only one I know of that mentioned using charsets besides utf-8 -- just an idea.

Note: as it relates to RFC 7231, we are in compliance now -- see where it says "or disregard the header field...". Again, I like better the use of status code 406, but probably implement it in version 8, reconfiguring the middleware to perform content type negotiation prior to execution of the GraphQL request.

Regarding encodings - spec become rather stric about encoding:

MUST is strong requirement )

graphql/graphql-over-http#229

src/Transports.AspNetCore/GraphQLHttpMiddlewareOptions.cs

sungam3r · 2022-09-19T18:20:32Z

src/Transports.AspNetCore/GraphQLHttpMiddlewareOptions.cs

@@ -95,7 +97,8 @@ public class GraphQLHttpMiddlewareOptions : IAuthorizationOptions
    public GraphQLWebSocketOptions WebSockets { get; set; } = new();

    /// <summary>
-    /// The Content-Type to use for GraphQL responses
+    /// The Content-Type to use for GraphQL responses, if it matches the 'Accept'


I read it several times and this comment still seems strange to me. I don't understand the meaning of matches.

I mean in generally I understand what you want to say but from the point of view of some "external" developer it may look strange.

I do the best I can. Sometimes I'm tongue tied. Here it seemed to make sense to me, but I get it. Feel free to suggest an improvement.

docs/migration/migration7.md

src/Transports.AspNetCore/GraphQLHttpMiddlewareOptions.cs

sungam3r · 2022-09-19T21:31:28Z

src/Transports.AspNetCore/GraphQLHttpMiddleware.cs

@@ -51,10 +54,12 @@ public class GraphQLHttpMiddleware : IUserContextBuilder
    private const string VARIABLES_KEY = "variables";
    private const string EXTENSIONS_KEY = "extensions";
    private const string OPERATION_NAME_KEY = "operationName";
-    private const string MEDIATYPE_GRAPHQLJSON = "application/graphql+json";
+    private const string MEDIATYPE_GRAPHQLJSON = "application/graphql+json"; // deprecated


Techically, it is not deprecated. It just does not exist anymore since they removed it from draft spec.

sungam3r · 2022-09-19T21:32:08Z

src/Transports.AspNetCore/GraphQLHttpMiddleware.cs

@@ -1,5 +1,8 @@
 #pragma warning disable CA1716 // Identifiers should not match keywords

+using Microsoft.Extensions.Primitives;
+using MediaTypeHeaderValueMs = Microsoft.Net.Http.Headers.MediaTypeHeaderValue;


There are two different MediaTypeHeaderValue classes both within scope (if I recall correctly).

sungam3r · 2022-09-19T22:04:38Z

src/Transports.AspNetCore/GraphQLHttpMiddleware.cs

+            }
+        }
+
+        // return the default content type if no match is found, or if there is no 'Accept' header


Hmm, what if client specified "application/pdf" or "application/some_unknown_mime" in accept header?

From https://datatracker.ietf.org/doc/html/rfc7231#section-5.3.2

A request without any Accept header field implies that the user agent
will accept any media type in response. If the header field is
present in a request and none of the available representations for
the response have a media type that is listed as acceptable, the
origin server can either honor the header field by sending a 406 (Not
Acceptable) response or disregard the header field by treating the
response as if it is not subject to content negotiation.

Do you want to go with second option?

That’s the case now (merged in this PR). Please read my response to your comments on this earlier today. TLDR: maybe update in v8 to reject with 406

sungam3r · 2022-09-19T22:28:05Z

src/Transports.AspNetCore/GraphQLHttpMiddleware.cs

+        }
+
+        // return the default content type if no match is found, or if there is no 'Accept' header
+        return _options.DefaultResponseContentType.ToString();


public override string ToString() { StringBuilder stringBuilder = new StringBuilder(); stringBuilder.Append(_mediaType); NameValueHeaderValue.ToString(_parameters, ';', leadingSeparator: true, stringBuilder); return stringBuilder.ToString(); }

😕 called each time

sungam3r · 2022-09-19T22:43:36Z

Reviewed. LGTM. I left some comments and posted #931

…4-upgrade-to-7.1 * commit 'af5ac03f9f5505d476850cee23c5aaa145110c94': (352 commits) Update response content type for `ExecutionResultActionResult` (graphql-dotnet#923) Bump Serilog.Sinks.Console from 4.0.1 to 4.1.0 (graphql-dotnet#924) Select return content type based on Accept header (graphql-dotnet#919) Allow the configuration of the response content type via options (graphql-dotnet#913) Change default response content type to match draft spec (graphql-dotnet#918) Add note regarding ASP.NET Core 2.1 support policy (graphql-dotnet#914) Bump Microsoft.NET.Test.Sdk from 17.3.0 to 17.3.1 (graphql-dotnet#920) Bump Shouldly from 4.0.3 to 4.1.0 (graphql-dotnet#912) Bump GraphQL to 7.0.2 (graphql-dotnet#911) Add file upload/download documentation to readme (graphql-dotnet#909) Fix packing readme and analysis recommendations (graphql-dotnet#897) Fix call to UseApolloTracing in Complex sample (graphql-dotnet#903) Add docs link Update migration document link (graphql-dotnet#895) Add federation tracing extension method (graphql-dotnet#894) Bump to GraphQL.NET 7.0.0 (graphql-dotnet#893) Feature/assembly-strongname (graphql-dotnet#892) Add JWT bearer authentication sample (graphql-dotnet#885) Bump Microsoft.AspNetCore.TestHost from 6.0.0 to 6.0.8 (graphql-dotnet#889) Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.3.0 (graphql-dotnet#890) ... # Conflicts: # src/Transports.AspNetCore/GraphQLExtensions.cs # src/Transports.AspNetCore/GraphQLHttpMiddleware.cs # src/Transports.AspNetCore/Transports.AspNetCore.csproj # src/Transports.Subscriptions.Abstractions/ProtocolMessageListener.cs # src/Transports.Subscriptions.Abstractions/Subscription.cs # src/Transports.Subscriptions.Abstractions/SubscriptionServer.cs # src/Transports.Subscriptions.Abstractions/Transports.Subscriptions.Abstractions.csproj # src/Transports.Subscriptions.WebSockets/GraphQlWebSocketsMiddleware.cs # src/Transports.Subscriptions.WebSockets/Transports.Subscriptions.WebSockets.csproj # src/Transports.Subscriptions.WebSockets/WebSocketConnection.cs # src/Transports.Subscriptions.WebSockets/WebSocketReaderPipeline.cs # src/Ui.GraphiQL/Ui.GraphiQL.csproj # src/Ui.Playground/Ui.Playground.csproj # src/Ui.Voyager/Ui.Voyager.csproj

Shane32 added 4 commits August 26, 2022 18:36

Change default response content type

cd5cad5

Smart content type

080552f

Merge

563656a

Update

b419913

Shane32 requested a review from sungam3r August 26, 2022 23:58

Shane32 self-assigned this Aug 26, 2022

github-actions bot added the test label Aug 26, 2022

Update

4f52583

Shane32 linked an issue Aug 28, 2022 that may be closed by this pull request

[Feature] Add proper support of Accept HTTP header #917

Closed

Shane32 mentioned this pull request Aug 28, 2022

Allow the configuration of the response content type via options #913

Merged

jeffw-wherethebitsroam reviewed Aug 29, 2022

View reviewed changes

Base automatically changed from change_default_response_content_type to master September 2, 2022 13:01

Merge

04a3317

Shane32 force-pushed the smart_content_type branch from 0eadde4 to 04a3317 Compare September 2, 2022 13:07

Shane32 added 2 commits September 2, 2022 10:25

Updates

1b87b95

Update

4c82572

github-advanced-security bot found potential problems Sep 2, 2022

View reviewed changes

Update

95719c6

github-advanced-security bot found potential problems Sep 2, 2022

View reviewed changes

Update

e01c2fa

Shane32 commented Sep 2, 2022

View reviewed changes

tests/ApiApprovalTests/net5+netcoreapp31/GraphQL.Server.Transports.AspNetCore.approved.txt Show resolved Hide resolved

Shane32 added enhancement New feature or request and removed test labels Sep 2, 2022

Shane32 merged commit 9fe3325 into master Sep 3, 2022

Shane32 deleted the smart_content_type branch September 3, 2022 16:05

Shane32 added this to the 7.0.1 milestone Sep 3, 2022

sungam3r reviewed Sep 19, 2022

View reviewed changes

src/Transports.AspNetCore/GraphQLHttpMiddlewareOptions.cs Show resolved Hide resolved

sungam3r reviewed Sep 19, 2022

View reviewed changes

docs/migration/migration7.md Show resolved Hide resolved

sungam3r reviewed Sep 19, 2022

View reviewed changes

src/Transports.AspNetCore/GraphQLHttpMiddlewareOptions.cs Show resolved Hide resolved

sungam3r reviewed Sep 19, 2022

View reviewed changes

sungam3r mentioned this pull request Sep 19, 2022

Saves a bit memory allocations on common path #931

Merged

This was referenced Sep 19, 2022

Return 406 on unsupported Accept header #932

Open

Come up with something for comments about Accept header #935

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Select return content type based on Accept header #919

Select return content type based on Accept header #919

Shane32 commented Aug 26, 2022

Shane32 commented Aug 28, 2022

jeffw-wherethebitsroam Aug 29, 2022

Shane32 Aug 29, 2022

codecov-commenter commented Sep 2, 2022

Shane32 commented Sep 2, 2022 •

edited

Loading

jeffw-wherethebitsroam commented Sep 5, 2022

bithavoc commented Sep 13, 2022

sungam3r Sep 19, 2022

Shane32 Sep 19, 2022

sungam3r Sep 19, 2022

Shane32 Sep 19, 2022

Shane32 Sep 19, 2022

sungam3r Sep 19, 2022

sungam3r Sep 19, 2022

sungam3r Sep 19, 2022

Shane32 Sep 20, 2022

sungam3r Sep 19, 2022

sungam3r Sep 19, 2022

Shane32 Sep 19, 2022

sungam3r Sep 19, 2022

sungam3r Sep 19, 2022

Shane32 Sep 19, 2022

sungam3r Sep 19, 2022

Shane32 Sep 19, 2022

sungam3r Sep 19, 2022

sungam3r commented Sep 19, 2022

Select return content type based on Accept header #919

Select return content type based on Accept header #919

Conversation

Shane32 commented Aug 26, 2022

Shane32 commented Aug 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Sep 2, 2022

Codecov Report

Shane32 commented Sep 2, 2022 • edited Loading

jeffw-wherethebitsroam commented Sep 5, 2022

bithavoc commented Sep 13, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sungam3r commented Sep 19, 2022

Shane32 commented Sep 2, 2022 •

edited

Loading