Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade informational messages from warning level #1784

Open
wants to merge 2 commits into
base: maintenance/gramps52
Choose a base branch
from

Conversation

hgohel
Copy link
Member

@hgohel hgohel commented Oct 10, 2024

Fixes 13464

In upgrade scenarios informational messages that indicate old config files are being imported into the new config are now being treated as informational rather than warnings which may alarm the reader.

Fixes 13464

In upgrade scenarios informational messages that indicate old config files are being imported into the new config are now being treated as informational rather than warnings which may alarm the reader.
@emyoulation
Copy link
Contributor

emyoulation commented Oct 10, 2024

I both like and dislike this change.

Informational is probably more accurate than warning. However, both are inconspicuous to a user unless launching from the console.

Config imports are an exceedingly rare occurrence with more than enough time between to forget the implications. Perhaps a more prominent (and explicit and, perhaps, modal) dialog should appear? (With hotlink to a wiki article.)

I'd like to have the dialog state which config file(s) are being imported. As an example, if I flushed the 5.2 gramps.ini (perhaps due to windows appearing off-screen) then I would want to know that a 5.1 gramps.ini is being imported. That could undermine my objective.

Likewise, it is important information if my User Directory isn't in the default 5.2 path due to the existence of a legacy 5.1 User Directory.

@hgohel
Copy link
Member Author

hgohel commented Oct 10, 2024

Thanks for reviewing the PR. This change does not remove the message from being shown in the console so whatever the reader did previously, they can continue to do that after this change, without being alarmed :)

If there is a desire to make the messages more conspicuous, a new feature request would be best to handle that.

@emyoulation
Copy link
Contributor

Agreed about a feature request. Just wanted to see if there is a consensus first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants