Fix Bug0013415 and 0013423 #1772
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The is_valid() method for a Date simply checks the sortval for a zero value. However, if an empty date is passed to _calc_sort_value() it first adjusts to 1 ALL y,m,d values that are zero. Thus, an empty date would return a sortval for the year 1-1-1 as a valid date.
This change to the unit-test code date_test.py is required so that the previous commit for bug #0013415 can pass the test. The problematic part of the test calculates an age for somebody with a birth date of "" (an empty string) and a death date given by a year, such as 1760. The previous test code required it to report "greater than 110 years", which should not be a suitable response. The previous code also reported an age of negative 1999 years for a birth year of 2000 and a death date of the empty string. The unit test code now tests against a reply of "unknown".
The test is skipped for locales other than en_US, but the message simply reported that the locale had to be English, which is baffling for anybody with an English locale other than US.
|
Commits should be atomic; i.e., the first two commits are related and should be the same commit (though if this PR is squash-merged then that issue is moot.) |
QuLogic
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three commits, to fix the sortval bug and corresponding unit test. These need to go together to allow tests to pass.
The 3rd component is a trivial improvement to warning message when date unit tests are skipped.