Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove InteractiveSearchBox entirely #1769

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove InteractiveSearchBox entirely #1769

wants to merge 1 commit into from

Commits on Sep 8, 2024

  1. Remove InteractiveSearchBox entirely 

    This widget was added in d426f62 as a
copy of the original `GtkTreeView` code, with a modified timeout to the
start of searching. Since then, there has been 1 additional change to
functionality in bb26e53 to add support
for a slightly different version of `PersistentTreeView` on `ListView`.
All other changes have been minimal maintenance: fixing small bugs,
replacing deprecated GTK calls, or code formatting.

I contend that this is too much code to maintain for such a small change
in functionality from upstream GTK, and any migration to new widgets in
GTK4 will have to implement this differently anyway, so I'm proposing to
remove it all. AFAICT, it still works, just with GTK's timing instead.
    @QuLogic
    QuLogic committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    74b0204 View commit details
    Browse the repository at this point in the history