Replace deprecated Gdk.Color by Gdk.RGBA #1764
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been deprecated since GDK 3.14.
QuLogic
force-pushed
the
drop-gdkcolor
branch
from
e873b73
to
df2c405
Compare
QuLogic
commented
Sep 5, 2024
Comment on lines
-398
to
-401
| self.line_color = rgb2color(g.get_color()) | ||
| self.top.get_object("line_color").set_color(self.line_color) | ||
| self.fill_color = rgb2color(g.get_fill_color()) | ||
| self.top.get_object("fill_color").set_color(self.fill_color) |
There was a problem hiding this comment.
Note that I couldn't find any use of self.line_color/self.fill_color in this file (e.g., the corollary to this function, save_graphics, does not use them), so I think that assignment was a mistake.
Comment on lines
-662
to
-663
| if isinstance(color, str): | ||
| color = Gdk.color_parse(color) |
There was a problem hiding this comment.
This function (animate_moves) is only a callback from a timeout added in _createmap, or a timeout added by itself, so we know the input is a Gdk.RGBA, and this check can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been deprecated since GDK 3.14.