-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Hebrew prefixes #1496
Add support for Hebrew prefixes #1496
Conversation
Nick-Hall
commented
Aug 6, 2023
- Double the Vav if not already double
- Remove the leading He
- Prefix a maqaf for non-Hebrew words and numbers
Does it cover some words/dates into others locales too? ../gramps/plugins/lib/libnarrate.py:88 and later |
These items seem to be creating sentence fragments (or 'asides') rather than stilted narrative sentences that would be grammatically correct. So, in English, rules of grammar do not apply. More properly in English, the event is 'on' a day and, when approximated, 'in' month or year. And while English lacks a masculine/feminine difference for 'born'. We would have to insert a pronoun to be equivalent... which would raise arguments about the "preferred pronoun". And it would require a modified verb. In this case, that would be: 'was', the (first and third person) singular past tense of 'be'. So if we were writing for a grammatically correct narrative in English, the examples would generate either specifically: But this example is narrative is generating an outline of facts (or 'asides') with informal sentence fragments instead. Are sentence fragments allowable in French? |
On report, the current gender handling sould be fine (grammar, wording) with most "latin" locales. But @emyoulation is maybe pointing out an other specific issue with date format, as the "french" date handler can also display date for users (and records) with "North American" culture (I think on the Canada country) . Where the "month day year" can be the prefered one (date format)...
But such above sentences with reported specific cases might also sound strange in English too, no? So, as this PR #1496 is for prefixes support, maybe the "in %()s", "on %()s", "at %()s" variables might be also "new clients" for a possible move to the prefixes support? RTL and LTR handling and maintenance could be also more "global" whatever locales (hardcoded or not - code, translation in memory or on the fly) ? |
Oh, with the "latin" flexibility, maybe everything is allowed! You can push/put two words on a paper, and the reader may (or not) understand the sense. So for detailed reports, "fragments" are maybe not allowed by the 'academie-francaise' or the 'office québécois de la langue française', but like with recents spelling reforms, the rules are only strict, in theory. So, if the common langage is understandable, one can blame you and someone else will be just keep the sense, the idea, behind sentence fragments! |
It doesn't at the moment, but it could do. It looks like for French we may need to pass in a Date or Place object in addition to the substitution text. |
@Nick-Hall , there is also a possible issue on a options sequence under textual detailed reports. User choice like:
can force to use a specific preposition... In this case (year only), I suppose this will not always display something like "in %(year)s" (for english), whatever date format set or locale issue. So, this may already pass over into some strings! |
Looking on internet ("'In' vs. 'On' followed by a year", found such answer:
|
It looks amazing so far, I'll test it in the UI after the approval to make sure it covers all cases, thank you so much! |
* Double the Vav if not already double * Remove the leading He * Prefix a maqaf for non-Hebrew words and numbers
7703cb6
into
gramps-project:maintenance/gramps52