Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI-Examples] Add Candle ML framework example #31

Open
wants to merge 2 commits into
base: intel_tdx
Choose a base branch
from

Conversation

dimakuv
Copy link
Contributor

@dimakuv dimakuv commented Jul 10, 2024

Description of the changes

This PR consists of two commits:

  • [CI-Examples] Add Candle ML framework example
  • [LibOS] Add shared_cpu_list file to sysfs cache info

The latter is a prerequisite for the former.

The Candle app is added for TDX benchmarking purposes. I also submitted the same patches (as two separate PRs) to mainline Gramine:

How to test this PR?

Follow the README of the Candle example.


This change is Reviewable

Copy link
Contributor Author

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion

a discussion (no related file):
Blocking comment: these changes must be merged in mainline Gramine, and then Gramine-TDX must be rebased on top of master. Then this PR won't be needed at all -- currently keeping it here for convenience.


Copy link
Contributor Author

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions


-- commits line 22 at r2:
Move to separate PR and merge

Copy link
Contributor Author

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion, "fixup! " found in commit messages' one-liners


-- commits line 22 at r2:

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

Move to separate PR and merge

Done, see #32

@dimakuv dimakuv force-pushed the dimakuv/add-candle-rust-example branch 2 times, most recently from dd23d1d to e4a50ef Compare July 15, 2024 09:01
Copy link
Contributor Author

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 8 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

@dimakuv dimakuv force-pushed the dimakuv/add-candle-rust-example branch 2 times, most recently from 7c5301c to 979ada9 Compare July 19, 2024 08:48
This is e.g. required by the gemm-common Rust crate, see
`gemm-common/src/cache.rs`. Without this file, the crate logic
incorrectly calculates shared-cpu count as zero and leads to a
division-by-zero exception.

Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
Candle is a minimalist ML framework for Rust with a focus on performance
and ease of use. This commit adds two examples with Candle: simple
matrix multiplication (to quickly test functionality) and Quantized
LLaMA (to test performance).

Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
@dimakuv dimakuv force-pushed the dimakuv/add-candle-rust-example branch from 979ada9 to a7fb30c Compare July 19, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant