Fix broken distribution

[matrei]

No description provided.

[matrei]

In Grails 6 (and earlier), which used the legacy org.gradle.api.tasks.Upload type for the installToHomeDist task, file hashes were calculated and saved together with the jars. Now that the Upload task is removed in Gradle 8, we use org.gradle.api.tasks.Copy instead. Copy does not generate these hash files automatically.

Do we want to continue generating these *.sha1, *.sha256 and *.sha512 files for the jar files in the dist folder?
Or was this just a side-effect of using the Upload task?

[jamesfredley]

I do not believe we need the SHA's based on the following:

• https://github.com/grails/grails-forge/releases/download/v6.2.1/grails-cli-6.2.1.zip
• https://dlcdn.apache.org/tomcat/tomcat-10/v10.1.31/bin/apache-tomcat-10.1.31.zip
• https://github.com/micronaut-projects/micronaut-starter/releases/download/v4.6.3/micronaut-cli-4.6.3.zip

[jamesfredley]

The distribution builds great. When run, I am seeing

Exception: java.lang.NoSuchMethodError thrown from the UncaughtExceptionHandler in thread "main"

digging down further:

> Task :grails-shell:org.grails.cli.GrailsCli.main() FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.10.2/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
10 actionable tasks: 1 executed, 1 from cache, 8 up-to-date
org.grails.cli.compiler.grape.DependencyResolutionFailedException: org.grails.cli.compiler.grape.DependencyResolutionFailedException: org.eclipse.aether.resolution.DependencyResolutionException: The following artifacts could not be resolved: org.grails:grails-bom:pom: (absent): Could not find artifact org.grails:grails-bom:pom: in grailsCentral (https://repo.grails.org/grails/core)
	at org.grails.cli.compiler.grape.MavenResolverGrapeEngine.resolve(MavenResolverGrapeEngine.java:284)
	at org.grails.cli.compiler.grape.MavenResolverGrapeEngine.resolve(MavenResolverGrapeEngine.java:268)
	at org.grails.cli.boot.GrailsDependencyVersions.<init>(GrailsDependencyVersions.groovy:55)
	at org.grails.cli.boot.GrailsDependencyVersions.<init>(GrailsDependencyVersions.groovy:51)
	at org.grails.cli.profile.repository.MavenProfileRepository.<init>(MavenProfileRepository.groovy:54)
	at org.grails.cli.GrailsCli.createMavenProfileRepository(GrailsCli.groovy:347)
	at org.grails.cli.GrailsCli.execute(GrailsCli.groovy:243)
	at org.grails.cli.GrailsCli.main(GrailsCli.groovy:161)
Caused by: org.grails.cli.compiler.grape.DependencyResolutionFailedException: org.eclipse.aether.resolution.DependencyResolutionException: The following artifacts could not be resolved: org.grails:grails-bom:pom: (absent): Could not find artifact org.grails:grails-bom:pom: in grailsCentral (https://repo.grails.org/grails/core)
	at org.grails.cli.compiler.grape.MavenResolverGrapeEngine.resolve(MavenResolverGrapeEngine.java:297)
	at org.grails.cli.compiler.grape.MavenResolverGrapeEngine.resolve(MavenResolverGrapeEngine.java:276)
	... 7 more
Caused by: org.eclipse.aether.resolution.DependencyResolutionException: The following artifacts could not be resolved: org.grails:grails-bom:pom: (absent): Could not find artifact org.grails:grails-bom:pom: in grailsCentral (https://repo.grails.org/grails/core)
	at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies(DefaultRepositorySystem.java:365)
	at org.grails.cli.compiler.grape.MavenResolverGrapeEngine.resolve(MavenResolverGrapeEngine.java:292)
	... 8 more
Caused by: org.eclipse.aether.resolution.ArtifactResolutionException: The following artifacts could not be resolved: org.grails:grails-bom:pom: (absent): Could not find artifact org.grails:grails-bom:pom: in grailsCentral (https://repo.grails.org/grails/core)
	at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:473)
	at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:261)
	at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies(DefaultRepositorySystem.java:353)
	... 9 more
Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact org.grails:grails-bom:pom: in grailsCentral (https://repo.grails.org/grails/core)
	at org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed(ArtifactTransportListener.java:42)
	at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:417)
	at org.eclipse.aether.connector.basic.BasicRepositoryConnector.get(BasicRepositoryConnector.java:260)
	at org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:537)
	at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:449)
	... 11 more

Exception: java.lang.NoSuchMethodError thrown from the UncaughtExceptionHandler in thread "main"

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':grails-shell:org.grails.cli.GrailsCli.main()'.

it is this line:

grails-core/grails-shell/src/main/groovy/org/grails/cli/boot/GrailsDependencyVersions.groovy

Line 51 in 7db9a62

this(grape, [group: "org.grails", module: "grails-bom", version: GrailsDependencyVersions.package.implementationVersion, type: "pom"])

The POM files are published on https://repo.grails.org/ui/repos/tree/PomView/libs-snapshots-local/org/grails/grails-bom/7.0.0-SNAPSHOT/grails-bom-7.0.0-20241014.150731-91.pom

This is also causing these 2 test failures:

https://github.com/search?q=repo%3Agrails%2Fgrails-core%20bom%3Apom&type=code

[matrei]

@jamesfredley That's interesting, I manage to run the distribution built on this branch:

mattias@mattias-xps:/mnt/c/Users/matti/Projects/github/grails-core/build/distributions$ ./grails-7.0.0-SNAPSHOT/bin/grails -version
| Grails Version: 7.0.0-SNAPSHOT
| JVM Version: 17.0.12
mattias@mattias-xps:/mnt/c/Users/matti/Projects/github/grails-core/build/distributions$ ./grails-7.0.0-SNAPSHOT/bin/grails
| Starting interactive mode...
| Enter a command name to run. Use TAB for completion:
grails>

[jamesfredley]

I am still digging into the cause here.

GrailsDependencyVersions.package.implementationVersion being null, was causing "Could not find artifact org.grails:grails-bom:pom", at least on Windows 11.

openjdk version "17.0.12" 2024-07-16 LTS
OpenJDK Runtime Environment Corretto-17.0.12.7.1 (build 17.0.12+7-LTS)
OpenJDK 64-Bit Server VM Corretto-17.0.12.7.1 (build 17.0.12+7-LTS, mixed mode, sharing)

[matrei]

@jamesfredley Does building and running a distribution from the 6.2.x branch work on Windows 11?

[matrei]

I tested 6.2.x. It runs fine on Windows 11. With 7.0.x I also get:
Exception: java.lang.NoSuchMethodError thrown from the UncaughtExceptionHandler in thread "main"

[jamesfredley]

@matrei do you want to move Exception: java.lang.NoSuchMethodError thrown from the UncaughtExceptionHandler in thread "main" over to a new issue and merge this one? If so I approve.