Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Sitemesh - Step 2 #13118

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Conversation

codeconsole
Copy link
Contributor

Change 1:

GrailsRoutablePrintWriter needs to be moved in a non-breaking way so that GSPResponseWriter doesn't depend on grails-web-sitemesh.

In order to do this in a non breaking way without circular dependencies, this class should be moved to the grails-encoder package.

A subsequent release of grails-gsp can then remove the class after GSPResponseWriter is updated to depend on the new package.

Change 2:

GrailsLayoutDecoratorMapper has 3 constants that are simply redundant references to GroovyPageLayoutFinder. The references should be updated directly to GroovyPageLayoutFinder so that both classes are not required when trying to resolve the value.

The reason for referencing them in GroovyPageLayoutFinder instead of moving them into GrailsLayoutDecoratorMapper is because GroovyPageLayoutFinder can not be removed from ResponseRenderer.groovy without breaking plugins that have previously compiled controllers using an earlier version of this trait.

@puneetbehl puneetbehl merged commit 1c71351 into grails:6.0.x Sep 5, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants