CI: Split gh workflow generate commands into a matrix #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
added
chore
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
jackw
force-pushed
the
jackw/gh-action-matrix
branch
from
d1a5a67
to
38c45dc
Compare
jackw
changed the title
jackw
force-pushed
the
jackw/gh-action-matrix
branch
from
d8ebc92
to
d5c08b5
Compare
andresmgot
reviewed
Oct 26, 2023
|
|
||
| generate-plugins: | ||
| name: Test plugin scaffolding | ||
| if: "!contains(github.event.head_commit.message, 'ci skip') && !contains(github.event.head_commit.message, 'skip ci')" |
There was a problem hiding this comment.
maybe it's better to use a label for this? Also, why would you want to skip the CI?
There was a problem hiding this comment.
This workflow runs on push and when a package in this repo is published we push changes to main and the commit message contains these strings so we can bypass unnecessary workflow runs.
andresmgot
approved these changes
Oct 26, 2023
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR splits the
generate-<pluginType>commands into a matrix to try to improve the times and also so we can run commands as individual steps against the scaffolded plugin rather than doing it as a one liner ofnpm exec nx run @grafana/create-plugin:generate-app-backend && (cd ./packages/create-plugin/generated && npm install && npm run build && npm run lint && mage -v build:linux).To speed up these tasks further we need to figure out what is going on with
npm ciwhich seems to be taking ages.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: