Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node 22 #1298

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Support node 22 #1298

merged 2 commits into from
Nov 11, 2024

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Nov 4, 2024

What this PR does / why we need it:

Node 22 is now LTS. This PR adds support for Node 22 in plugin-e2e (and removes the upper bound) and changes the node engine in scaffolded plugins to 22. Also changing all workflows (local and scaffolded) to use 22.

We'll remove support for node 18 entirely once it's moved out of maintenance LTS.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Will add a follow up PR that bumps node version in the examples repo.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/[email protected]
npm install @grafana/[email protected]
# or 
yarn add @grafana/[email protected]
yarn add @grafana/[email protected]

Copy link

github-actions bot commented Nov 4, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@sunker sunker added patch Increment the patch version when merged release Create a release when this pr is merged dependencies Update one or more dependencies version minor Increment the minor version when merged and removed patch Increment the patch version when merged labels Nov 4, 2024
@sunker sunker marked this pull request as ready for review November 4, 2024 09:57
@sunker sunker requested a review from a team as a code owner November 4, 2024 09:57
@sunker sunker requested review from Ukochka and removed request for a team November 4, 2024 09:57
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tolzhabayev
Copy link
Collaborator

Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

packages/plugin-e2e/package.json Outdated Show resolved Hide resolved
@sunker sunker merged commit 699665b into main Nov 11, 2024
20 checks passed
@sunker sunker deleted the chore/support-node-22 branch November 11, 2024 11:18
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/[email protected], @grafana/[email protected], [email protected] 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

5 participants