helm: support for setting internalTrafficPolicy in k8s services #9619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Wouldn't it be equally valuable to have this feature in other mimir services, e.g. in |
Yeah, could be useful, I can add it to the rest. I think the most important is for the ingress direction. |
kovaxur
force-pushed
the
traffic-policy
branch
3 times, most recently
from
a78c881
to
9efbef9
Compare
narqo
reviewed
Oct 16, 2024
operations/helm/charts/mimir-distributed/templates/memcached/_memcached-svc.tpl
Outdated
Show resolved
Hide resolved
kovaxur
force-pushed
the
traffic-policy
branch
from
9efbef9
to
34ba2a1
Compare
…bernetes services. Enable internalTrafficPolicy only from Kubernetes version 1.22 or above. Signed-off-by: Daniel Kovacs <[email protected]>
kovaxur
force-pushed
the
traffic-policy
branch
from
34ba2a1
to
5061ea4
Compare
|
Overall, the changes look good to me. But the CI's found that this broke some known use-cases. Try running Alternatively, this also seems to show the problem: |
… use the global function to determine the cluster version Signed-off-by: Daniel Kovacs <[email protected]>
Signed-off-by: Daniel Kovacs <[email protected]>
narqo
approved these changes
Oct 18, 2024
Signed-off-by: Vladimir Varankin <[email protected]>
narqo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Allows users to add internalTrafficPolicy to the Kubernetes Service of Ingester and Distributor.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.