Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: fix errors on autoscaling metrics after series churn #9412

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

dimitarvdimitrov
Copy link
Contributor

What this PR does

The promQL joins would fail when the series churn. For example, when
there are labels added by scrapers or when the K8s exporter restarts
and gets a new pod label.

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: Dimitar Dimitrov <[email protected]>
The promQL joins would fail when the series churn. For example, when
there are labels added by scrapers or when the K8s exporter restarts
and gets a new `pod` label.

Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@dimitarvdimitrov dimitarvdimitrov merged commit 8d3c2c6 into main Sep 26, 2024
31 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/mixin/fix-autoscaling-metrics branch September 26, 2024 08:21
@pracucci pracucci mentioned this pull request Sep 27, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants