Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify fs/streams/csv docs to reflect top-level await support #1798

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

oleiade
Copy link
Member

@oleiade oleiade commented Nov 5, 2024

What?

This PR modifies the documentation of the fs/streams/csv modules to reflect the availability of top-level (init context) support for the await keyword.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

@oleiade oleiade added the Area: OSS Content Improvements or additions to community/oss documentation label Nov 5, 2024
@oleiade
Copy link
Member Author

oleiade commented Nov 6, 2024

I don't understand with the doc-validator job fails here. @heitortsergent any insights on why that might happen? 🙇🏻

@oleiade oleiade merged commit 2614b96 into main Nov 7, 2024
2 of 3 checks passed
@oleiade oleiade deleted the feature/top_level_await_with_fs branch November 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OSS Content Improvements or additions to community/oss documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant