Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added extension list #28

Merged
merged 6 commits into from
Aug 27, 2024
Merged

feat: added extension list #28

merged 6 commits into from
Aug 27, 2024

Conversation

szkiba
Copy link
Contributor

@szkiba szkiba commented Jul 30, 2024

It is usual for awesome lists that although the list is longer, the list directly contains links to resources. In addition to the GitHub topic search (xk6), it is advisable to add a list of popular extensions.

Extensions supported by Grafana and supported by the community have been placed in separate sections. The community-supported extension list initially contains registered extensions whose repository has ten or more stars. Later, this list will be maintained by the community (in the form of PRs).

@szkiba szkiba requested a review from a team as a code owner July 30, 2024 15:32
@szkiba szkiba requested review from pablochacin and removed request for a team July 30, 2024 15:32
@szkiba szkiba linked an issue Jul 30, 2024 that may be closed by this pull request
@szkiba szkiba requested a review from andrewslotin July 30, 2024 15:33
Copy link
Collaborator

@andrewslotin andrewslotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just added suggestions to move two extensions out of the "Community" section.

README.md Outdated Show resolved Hide resolved
README.md Outdated
### Community

- [xk6-cable](https://github.com/anycable/xk6-cable) - Test Action Cable and AnyCable functionality.
- [xk6-client-prometheus-remote](https://github.com/grafana/xk6-client-prometheus-remote) - Test Prometheus Remote Write performance.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this extension can be considered officially supported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll move it to the official section. Could you please open a PR in the k6-docs repo by setting the official flag to true for this extension.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above PR is merged now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I moved to official section

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@pablochacin pablochacin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@andrewslotin andrewslotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for taking care of this!

@szkiba szkiba merged commit b494d49 into main Aug 27, 2024
2 checks passed
@szkiba szkiba deleted the 27-add-extension-list branch August 27, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extension list
3 participants