Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow activate bookmark by doubleclik in plotter #1174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pinkavaj
Copy link
Contributor

Close #214

@vladisslav2011
Copy link
Contributor

Isn't it better to use right-click, like it is done here: ff69939 ?

@pinkavaj
Copy link
Contributor Author

Isn't it better to use right-click, like it is done here: ff69939 ?

It is definitely an option. My conclusion was doubleclick will produce more consistent behavior. AFAIK rightclick is now used to either pop-up menus or to reset number to zero in frequency selection box. Doubleclick is used in bookmarks dock to activate the bookmark. This is not menu but does aktivate the bookmark.

Doing UI might get tricky and honestly I did not get through whole app to find out every usage of double/righ-click. I'm open to discussion but for now confident this good choice.

@vladisslav2011
Copy link
Contributor

Doubleclick in a bookmarks dock by default switches the cell to editing state, so using it to activate a bookmark is not the best possible option. It may better to use a context menu like it is done here: f8c7856
It may be better to add a context menu to a plotter. I decided to not do so and leave default right click to reset zoom/offset action and override right click over a bookmark tag only.
Consider taking a look at this branch https://github.com/vladisslav2011/gqrx/tree/multi_vfo_unsquashed and suggesting commits, that worth opening a separate PR to make #1106 smaller and easier to review.

@pinkavaj
Copy link
Contributor Author

Wow, it seems to be even more complicated. On build from latest master (53bd3c50) I observe this behavior in bookmark dock:

#1175

Do you observe the same behavior? @vladisslav2011

My gut feeling is this should be make consistent in the first place.

@vladisslav2011
Copy link
Contributor

I can confirm the same behavior.
This behavior is fine to me, so I have not opened an issue about it.

There may be at least 2 possible actions, that may be assigned to a doubleclick: just tune to a bookmarked frequency and tune to a bookmarked frequency and load settings. There may be the third action in the future: to create a VFO at a bookmarked frequency.

Which action should be executed by default?
Should we add an alternate action (or both) to a context menu?

@argilo argilo added the feature label Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting a bookmark doesn't retrieve all saved settings
4 participants