forked from raystack/transformers
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add retry timeout #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deryrahman
force-pushed
the
bqclient-retry
branch
from
April 18, 2024 08:55
1f437c5
to
0786a75
Compare
deryrahman
force-pushed
the
bqclient-retry
branch
from
April 18, 2024 09:08
0786a75
to
ffa0543
Compare
arinda-arif
reviewed
Apr 22, 2024
deryrahman
force-pushed
the
bqclient-retry
branch
from
April 23, 2024 06:32
14554cb
to
6cecff3
Compare
arinda-arif
reviewed
Apr 23, 2024
deryrahman
force-pushed
the
bqclient-retry
branch
from
April 23, 2024 07:30
6cecff3
to
dc6aec4
Compare
deryrahman
force-pushed
the
bqclient-retry
branch
from
April 23, 2024 08:05
084e512
to
b084279
Compare
deryrahman
force-pushed
the
bqclient-retry
branch
from
April 23, 2024 08:06
b084279
to
9dea8ca
Compare
arinda-arif
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please do a final round of testing before merging, due to recent changes.
Thank you
deryrahman
force-pushed
the
bqclient-retry
branch
from
April 24, 2024 04:29
7547e9f
to
80800df
Compare
arinda-arif
pushed a commit
that referenced
this pull request
Jul 8, 2024
* feat: add retry timeout * feat: upgrade bigquery client version + add timeout as a predicate to retry * feat: rename retry config env * feat: include SSLError as error worth to retry * feat: add log level config * fix: assigned retry object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retry_timeout_in_seconds
configuration to configure custom timeout on retry