feat: Show MR info in schema change

Makefile

@@ -1,6 +1,6 @@
 NAME="github.com/goto/stencil"
 VERSION=$(shell git describe --always --tags 2>/dev/null)
-PROTON_COMMIT := "4acac160b663d97d64cab017dcb08c787eec3e1d"
+PROTON_COMMIT := "6bc4e5b240f0fd8a2dab4696c570a9c9a6a692ec"
 EXCLUDE_FILES :=./test_utils/testutils.go
 .PHONY: all build test clean dist vet proto install ui
 

core/changedetector/change_detector.go

@@ -10,6 +10,8 @@ type ChangeRequest struct {
 	OldData     []byte
 	NewData     []byte
 	Depth       int32
+	SourceURL   string
+	CommitSHA   string
 }
 
 type NotificationEvent struct {

core/changedetector/proto_change_detector_service.go

@@ -51,6 +51,10 @@ func (s *Service) IdentifySchemaChange(ctx context.Context, request *ChangeReque
 		NamespaceName:  request.NamespaceID,
 		SchemaName:     request.SchemaName,
 		Version:        request.Version,
+		Metadata: &stencilv1beta1.Metadata{
+			SourceUrl: request.SourceURL,
+			CommitSha: request.CommitSHA,
+		},
 	}
 	setDirectlyImpactedSchemasAndFields(currentFds, prevFds, sce)
 	reverseDependencies := getReverseDependencies(currentFds)

core/changedetector/proto_change_detector_service_test.go

@@ -32,6 +32,8 @@ func init() {
 		SchemaName:  "testSchemaName",
 		Version:     int32(1),
 		Depth:       10,
+		SourceURL:   "https://github.com/some-repo",
+		CommitSHA:   "some-commit-sha",
 	}
 }
 
@@ -256,6 +258,7 @@ func assertSchemaChangeEvent(t *testing.T, expected, actual *stencilv1beta2.Sche
 	assert.ElementsMatch(t, expected.UpdatedSchemas, actual.UpdatedSchemas)
 	assertUpdatedFields(t, expected.UpdatedFields, actual.UpdatedFields)
 	assertImpactedSchemas(t, expected.ImpactedSchemas, actual.ImpactedSchemas)
+	assert.Equal(t, expected.Metadata, actual.Metadata)
 }
 
 func assertUpdatedFields(t *testing.T, expected, actual map[string]*stencilv1beta2.ImpactedFields) {

core/changedetector/testdata/output/sce_enum_added.json

@@ -19,5 +19,9 @@
       ]
     }
   },
-  "version": 1
+  "version": 1,
+  "metadata": {
+    "source_url": "https://github.com/some-repo",
+    "commit_sha": "some-commit-sha"
+  }
 }

core/changedetector/testdata/output/sce_enum_fields_inside_message_added.json

@@ -32,5 +32,9 @@
       ]
     }
   },
-  "version": 1
+  "version": 1,
+  "metadata": {
+    "source_url": "https://github.com/some-repo",
+    "commit_sha": "some-commit-sha"
+  }
 }

core/changedetector/testdata/output/sce_enum_fields_inside_message_updated.json

@@ -30,5 +30,9 @@
       ]
     }
   },
-  "version": 1
+  "version": 1,
+  "metadata": {
+    "source_url": "https://github.com/some-repo",
+    "commit_sha": "some-commit-sha"
+  }
 }

core/changedetector/testdata/output/sce_enum_updated.json

@@ -18,5 +18,9 @@
       ]
     }
   },
-  "version": 1
+  "version": 1,
+  "metadata": {
+    "source_url": "https://github.com/some-repo",
+    "commit_sha": "some-commit-sha"
+  }
 }

core/changedetector/testdata/output/sce_fields_updated_with_dependencies.json

@@ -19,5 +19,9 @@
       ]
     }
   },
-  "version": 1
+  "version": 1,
+  "metadata": {
+    "source_url": "https://github.com/some-repo",
+    "commit_sha": "some-commit-sha"
+  }
 }

core/changedetector/testdata/output/sce_fields_updated_with_no_dependencies.json

@@ -18,5 +18,9 @@
       ]
     }
   },
-  "version": 1
+  "version": 1,
+  "metadata": {
+    "source_url": "https://github.com/some-repo",
+    "commit_sha": "some-commit-sha"
+  }
 }

core/changedetector/testdata/output/sce_new_message_added.json

@@ -19,5 +19,9 @@
       ]
     }
   },
-  "version": 1
+  "version": 1,
+  "metadata": {
+    "source_url": "https://github.com/some-repo",
+    "commit_sha": "some-commit-sha"
+  }
 }

core/changedetector/testdata/output/sce_new_message_added_negative_depth.json

@@ -22,5 +22,9 @@
       ]
     }
   },
-  "version": 1
+  "version": 1,
+  "metadata": {
+    "source_url": "https://github.com/some-repo",
+    "commit_sha": "some-commit-sha"
+  }
 }

core/changedetector/testdata/output/sce_new_message_added_one_depth.json

@@ -21,5 +21,9 @@
       ]
     }
   },
-  "version": 1
+  "version": 1,
+  "metadata": {
+    "source_url": "https://github.com/some-repo",
+    "commit_sha": "some-commit-sha"
+  }
 }

core/changedetector/testdata/output/sce_new_message_added_zero_depth.json

@@ -19,5 +19,9 @@
       ]
     }
   },
-  "version": 1
+  "version": 1,
+  "metadata": {
+    "source_url": "https://github.com/some-repo",
+    "commit_sha": "some-commit-sha"
+  }
 }

core/schema/schema.go

@@ -2,6 +2,7 @@ package schema
 
 import (
 	"context"
+
 	"google.golang.org/protobuf/proto"
 
 	"github.com/goto/stencil/core/changedetector"
@@ -12,6 +13,7 @@ type Metadata struct {
 	Authority     string
 	Format        string
 	Compatibility string
+	SourceURL     string
 }
 
 type SchemaInfo struct {
@@ -27,8 +29,15 @@ type SchemaFile struct {
 	Data   []byte
 }
 
+type UpdateSchemaRequest struct {
+	Namespace  string
+	Schema     string
+	Metadata   *Metadata
+	SchemaFile *SchemaFile
+}
+
 type Repository interface {
-	Create(ctx context.Context, namespace string, schema string, metadata *Metadata, versionID string, schemaFile *SchemaFile) (version int32, err error)
+	Create(ctx context.Context, request *UpdateSchemaRequest, versionID string, commitSHA string) (version int32, err error)
 	List(context.Context, string) ([]Schema, error)
 	ListVersions(context.Context, string, string) ([]int32, error)
 	Get(context.Context, string, string, int32) ([]byte, error)
@@ -62,6 +71,7 @@ type Schema struct {
 	Format        string
 	Compatibility string
 	Authority     string
+	SourceURL     string
 }
 
 type ChangeDetectorService interface {

core/schema/service.go

@@ -8,7 +8,6 @@ import (
 	"time"
 
 	"github.com/google/uuid"
-
 	"github.com/jackc/pgx/v4"
 
 	"github.com/goto/stencil/config"
@@ -100,7 +99,7 @@ func (s *Service) checkCompatibility(ctx context.Context, nsName, schemaName, fo
 	return checkerFn(current, []ParsedSchema{prevSchema})
 }
 
-func (s *Service) Create(ctx context.Context, nsName string, schemaName string, metadata *Metadata, data []byte) (SchemaInfo, error) {
+func (s *Service) Create(ctx context.Context, nsName string, schemaName string, metadata *Metadata, data []byte, commitSHA string) (SchemaInfo, error) {
 	endFunc := s.newrelic.StartGenericSegment(ctx, "Create Schema Info")
 	defer endFunc()
 	var scInfo SchemaInfo
@@ -121,10 +120,17 @@ func (s *Service) Create(ctx context.Context, nsName string, schemaName string,
 	mergedMetadata := &Metadata{
 		Format:        format,
 		Compatibility: compatibility,
+		SourceURL:     metadata.SourceURL,
 	}
 	versionID := getIDforSchema(nsName, schemaName, sf.ID)
 	_, prevSchemaData, err2 := s.GetLatest(ctx, nsName, schemaName)
-	version, err := s.repo.Create(ctx, nsName, schemaName, mergedMetadata, versionID, sf)
+	request := &UpdateSchemaRequest{
+		Namespace:  nsName,
+		Schema:     schemaName,
+		Metadata:   mergedMetadata,
+		SchemaFile: sf,
+	}
+	version, err := s.repo.Create(ctx, request, versionID, commitSHA)
 	if err != nil {
 		log.Printf("got error while creating schema %s in namespace %s -> %s", schemaName, nsName, err.Error())
 	}
@@ -139,6 +145,8 @@ func (s *Service) Create(ctx context.Context, nsName string, schemaName string,
 				OldData:     prevSchemaData,
 				NewData:     data,
 				Depth:       s.config.SchemaChange.Depth,
+				SourceURL:   metadata.SourceURL,
+				CommitSHA:   commitSHA,
 			}
 			go func() {
 				newCtx, cancel := context.WithTimeout(context.Background(), 1*time.Hour)