chore: send source url and commit sha in create Schema RPC (#45)

Co-authored-by: gagan.dhand <[email protected]>
goto · Jul 2, 2024 · 3e0923b · 3e0923b
1 parent 06a4a19
commit 3e0923b
Show file tree

Hide file tree

Showing 5 changed files with 556 additions and 498 deletions.
diff --git a/Makefile b/Makefile
@@ -1,6 +1,6 @@
 NAME="github.com/goto/stencil"
 VERSION=$(shell git describe --always --tags 2>/dev/null)
-PROTON_COMMIT := "6bc4e5b240f0fd8a2dab4696c570a9c9a6a692ec"
+PROTON_COMMIT := "4fb568dd9af09c7efeac3e60fc3a999e239d419a"
 EXCLUDE_FILES :=./test_utils/testutils.go
 .PHONY: all build test clean dist vet proto install ui
 

diff --git a/internal/api/schema.go b/internal/api/schema.go
@@ -24,8 +24,12 @@ func schemaToProto(s schema.Schema) *stencilv1beta1.Schema {
 }
 
 func (a *API) CreateSchema(ctx context.Context, in *stencilv1beta1.CreateSchemaRequest) (*stencilv1beta1.CreateSchemaResponse, error) {
-	metadata := &schema.Metadata{Format: in.GetFormat().String(), Compatibility: in.GetCompatibility().String()}
-	sc, err := a.schema.Create(ctx, in.NamespaceId, in.SchemaId, metadata, in.GetData(), "")
+	metadata := &schema.Metadata{
+		Format:        in.GetFormat().String(),
+		Compatibility: in.GetCompatibility().String(),
+		SourceURL:     in.GetSourceUrl(),
+	}
+	sc, err := a.schema.Create(ctx, in.NamespaceId, in.SchemaId, metadata, in.GetData(), in.GetCommitSha())
 	return &stencilv1beta1.CreateSchemaResponse{
 		Version:  sc.Version,
 		Id:       sc.ID,

diff --git a/proto/gotocompany/apidocs.swagger.json b/proto/gotocompany/apidocs.swagger.json
@@ -1,7 +1,7 @@
 {
   "swagger": "2.0",
   "info": {
-    "title": "gotocompany/stencil/v1beta1/stencil.proto"
+    "title": "gotocompany/stencil/v1beta1/stencil.proto",
     "version": "0.1.4"
   },
   "tags": [
@@ -553,6 +553,9 @@
         "updatedAt": {
           "type": "string",
           "format": "date-time"
+        },
+        "sourceUrl": {
+          "type": "string"
         }
       }
     },
@@ -667,6 +670,9 @@
         "updatedAt": {
           "type": "string",
           "format": "date-time"
+        },
+        "sourceUrl": {
+          "type": "string"
         }
       }
     },