feat: Optimus spec based siren alerts #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mryashbhardwaj
requested review from
arinda-arif and
sbchaos
and removed request for
arinda-arif
ahmadnaufal
reviewed
Nov 13, 2024
ext/scheduler/airflow/__lib.py
Outdated
| @@ -400,7 +400,7 @@ def get_run_type(context): | |||
| def job_success_event(context): | |||
| try: | |||
| meta = { | |||
| "event_type": "TYPE_JOB_SUCCESS", | |||
There was a problem hiding this comment.
yes this is needed
There was a problem hiding this comment.
No, actually you are right, this should not be done
fixing this
ahmadnaufal
reviewed
Nov 14, 2024
core/job/spec.go
Outdated
| @@ -560,14 +562,31 @@ type WebhookSpec struct { | |||
| Endpoints []WebhookEndPoint | |||
| } | |||
|
|
|||
| func NewAlertSpec(on string, channels []string, config Config) (*AlertSpec, error) { | |||
| const ( | |||
| DefaultSeverity = "INFO" | |||
There was a problem hiding this comment.
in here default severity is INFO, while in https://github.com/goto/optimus/pull/299/files#diff-ae8202ecdfcffa6355ad138f9caf0e43b8c5163a4a831e28be335bbcc3a66f2cR28 it is warning. Both should be warning, no?
There was a problem hiding this comment.
yes correct,
fixing this
|
other than the mentioned differences, PR looks good to me |
ahmadnaufal
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proton PR: goto/proton#137