fix: update replay details endpoint (#266)

* fix: update replay details endpoint * fix: update replay details endpoint
goto · Sep 24, 2024 · dbb19e1 · dbb19e1
1 parent 0634d6f
commit dbb19e1
Show file tree

Hide file tree

Showing 5 changed files with 81 additions and 50 deletions.
diff --git a/Makefile b/Makefile
@@ -5,7 +5,7 @@ NAME = "github.com/goto/optimus"
 LAST_COMMIT := $(shell git rev-parse --short HEAD)
 LAST_TAG := "$(shell git rev-list --tags --max-count=1)"
 OPMS_VERSION := "$(shell git describe --tags ${LAST_TAG})-next"
-PROTON_COMMIT := "750afa5b646347179ab2abaf3ea3b51ce03cc3ab"
+PROTON_COMMIT := "ca87ce40849dfc2a7a73ba9d2e0e9084e33dadeb"
 
 
 .PHONY: build test test-ci generate-proto unit-test-ci integration-test vet coverage clean install lint

diff --git a/ext/scheduler/airflow/__lib.py b/ext/scheduler/airflow/__lib.py
@@ -88,7 +88,7 @@ def _add_connection_adapter_if_absent(self, host):
 
     def get_job_replay_config(self, project_name,  job_name, schedule_time) -> dict:
         scheduled_at_str = schedule_time.strftime(TIMESTAMP_FORMAT)
-        url = '{optimus_host}/api/v1beta1/project/{optimus_project}/replay'.format(
+        url = '{optimus_host}/api/v1beta1/project/{optimus_project}/replay-details'.format(
             optimus_host=self.host,
             optimus_project=project_name,
         )

diff --git a/protos/gotocompany/optimus/core/v1beta1/replay.pb.go b/protos/gotocompany/optimus/core/v1beta1/replay.pb.go
diff --git a/protos/gotocompany/optimus/core/v1beta1/replay.pb.gw.go b/protos/gotocompany/optimus/core/v1beta1/replay.pb.gw.go
diff --git a/protos/gotocompany/optimus/core/v1beta1/replay.swagger.json b/protos/gotocompany/optimus/core/v1beta1/replay.swagger.json
@@ -23,12 +23,12 @@
   "paths": {
     "/v1beta1/project/{projectName}/replay": {
       "get": {
-        "operationId": "ReplayService_GetReplayDetails",
+        "operationId": "ReplayService_ListReplay",
         "responses": {
           "200": {
             "description": "A successful response.",
             "schema": {
-              "$ref": "#/definitions/v1beta1GetReplayDetailsResponse"
+              "$ref": "#/definitions/v1beta1ListReplayResponse"
             }
           },
           "default": {
@@ -44,35 +44,6 @@
             "in": "path",
             "required": true,
             "type": "string"
-          },
-          {
-            "name": "replayId",
-            "in": "query",
-            "required": false,
-            "type": "string"
-          },
-          {
-            "name": "jobNames",
-            "in": "query",
-            "required": false,
-            "type": "array",
-            "items": {
-              "type": "string"
-            },
-            "collectionFormat": "multi"
-          },
-          {
-            "name": "scheduledAt",
-            "in": "query",
-            "required": false,
-            "type": "string",
-            "format": "date-time"
-          },
-          {
-            "name": "status",
-            "in": "query",
-            "required": false,
-            "type": "string"
           }
         ],
         "tags": [
@@ -141,6 +112,65 @@
         ]
       }
     },
+    "/v1beta1/project/{projectName}/replay-details": {
+      "get": {
+        "operationId": "ReplayService_GetReplayDetails",
+        "responses": {
+          "200": {
+            "description": "A successful response.",
+            "schema": {
+              "$ref": "#/definitions/v1beta1GetReplayDetailsResponse"
+            }
+          },
+          "default": {
+            "description": "An unexpected error response.",
+            "schema": {
+              "$ref": "#/definitions/rpcStatus"
+            }
+          }
+        },
+        "parameters": [
+          {
+            "name": "projectName",
+            "in": "path",
+            "required": true,
+            "type": "string"
+          },
+          {
+            "name": "replayId",
+            "in": "query",
+            "required": false,
+            "type": "string"
+          },
+          {
+            "name": "jobNames",
+            "in": "query",
+            "required": false,
+            "type": "array",
+            "items": {
+              "type": "string"
+            },
+            "collectionFormat": "multi"
+          },
+          {
+            "name": "scheduledAt",
+            "in": "query",
+            "required": false,
+            "type": "string",
+            "format": "date-time"
+          },
+          {
+            "name": "status",
+            "in": "query",
+            "required": false,
+            "type": "string"
+          }
+        ],
+        "tags": [
+          "ReplayService"
+        ]
+      }
+    },
     "/v1beta1/project/{projectName}/replay-dry-run": {
       "post": {
         "operationId": "ReplayService_ReplayDryRun",