feat: added maxcompute configs support and placeholders for extractor implementation #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayurjag
force-pushed
the
feat/maxcompute-extractor
branch
from
2e9bad8
to
f822cef
Compare
Mayurjag
force-pushed
the
feat/maxcompute-extractor
branch
3 times, most recently
from
d736ae2
to
42c761a
Compare
haveiss
reviewed
Nov 7, 2024
Mayurjag
force-pushed
the
feat/maxcompute-extractor
branch
from
42c761a
to
44f63cb
Compare
haveiss
reviewed
Nov 11, 2024
haveiss
reviewed
Nov 11, 2024
haveiss
reviewed
Nov 11, 2024
haveiss
reviewed
Nov 11, 2024
haveiss
reviewed
Nov 11, 2024
| } | ||
|
|
||
| if tableInfo.Body.Data.CreationTime != nil { | ||
| attributesData["partition_field"] = *tableInfo.Body.Data.CreationTime |
There was a problem hiding this comment.
referred the RFC for this, lets discuss
Mayurjag
force-pushed
the
feat/maxcompute-extractor
branch
3 times, most recently
from
e5e5e23
to
db31a23
Compare
haveiss
reviewed
Nov 13, 2024
haveiss
reviewed
Nov 13, 2024
haveiss
reviewed
Nov 13, 2024
haveiss
reviewed
Nov 13, 2024
haveiss
reviewed
Nov 13, 2024
haveiss
reviewed
Nov 13, 2024
Mayurjag
force-pushed
the
feat/maxcompute-extractor
branch
from
db31a23
to
b076c1e
Compare
Mayurjag
force-pushed
the
feat/maxcompute-extractor
branch
2 times, most recently
from
59353d7
to
db3d6d0
Compare
Mayurjag
force-pushed
the
feat/maxcompute-extractor
branch
from
db3d6d0
to
34cfcde
Compare
haveiss
reviewed
Nov 14, 2024
go.mod
Outdated
Comment on lines
15
to
16
| github.com/alibabacloud-go/darabonba-openapi/v2 v2.0.10 | ||
| github.com/alibabacloud-go/maxcompute-20220104 v1.4.1 |
There was a problem hiding this comment.
this can be removed, no? please go mod tidy again while make sure you use go version 1.20.X
Comment on lines
+252
to
+255
| if tableInfo.ResourceUrl() != "" { | ||
| attributesData["resource_url"] = tableInfo.ResourceUrl() | ||
| } | ||
|
|
There was a problem hiding this comment.
I believe we still need partition_field information since it is P0. We can get from table.PartitionColumns() @Mayurjag
Mayurjag
force-pushed
the
feat/maxcompute-extractor
branch
from
03a843b
to
7b5cad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.