feat: grant dormancy check #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsushmith
reviewed
Aug 2, 2023
|
|
||
| s.logger.Info(fmt.Sprintf("getting active grants for provider %q", provider.URN)) | ||
| grants, err := s.List(ctx, domain.ListGrantsFilter{ | ||
| Statuses: []string{string(domain.GrantStatusActive)}, // TODO: evaluate later to use status_in_provider |
There was a problem hiding this comment.
Can you elaborate on the todo here and add a detailed comment if we are picking it up later.
Comment on lines
+650
to
+676
| func isSubset(subset, superset []string) bool { | ||
| checkset := make(map[string]bool) | ||
| for _, element := range subset { | ||
| checkset[element] = true | ||
| } | ||
| for _, element := range superset { | ||
| if checkset[element] { | ||
| delete(checkset, element) | ||
| } | ||
| } | ||
| return len(checkset) == 0 | ||
| } |
There was a problem hiding this comment.
test cases for this module
bsushmith
previously requested changes
Aug 2, 2023
mabdh
reviewed
Aug 7, 2023
Co-authored-by: sushmith <[email protected]>
rahmatrhd
force-pushed
the
dormant-access-revocation
branch
from
db52a8b
to
4f30781
Compare
mabdh
approved these changes
Aug 16, 2023
rahmatrhd
dismissed
bsushmith’s stale review
requested changes already made previously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.