Merge upstream changes localy #3
Conversation
It also works on i386 architecture.
Remove amd64 directive
Add GoDoc link
simple numeric name check should suffice. Otherwise, it is pretty problematic to query processes on systems with SELinux in enforcing mode as it is complicated to open access to _all_ files inside proc. The reason this catch-all access is required is that with os.Readdir it needs to lstat each entry to return os.FileInfo and this requires additional permissions on each disperate file type inside /proc which is not easy to catch with an attribute (as it is with processes).
Update process fetcher to support SELinux-enabled systems.
…gravitational-master
Adding Power Support
Updating go version to 1.13 as the lower versions are not supported.
AddingPowerSupport_&_CI/Testing
Remove .travis.yml as Travis-CI is basically dead.
go.mod
Outdated
| @@ -0,0 +1,3 @@ | |||
| module github.com/mitchellh/go-ps | |||
| @@ -1,4 +1,4 @@ | |||
| # Process List Library for Go | |||
| # Process List Library for Go [](https://godoc.org/github.com/mitchellh/go-ps) | |||
There was a problem hiding this comment.
I think we would also need to change these urls?
There was a problem hiding this comment.
Maybe the README could be replaced completely and detail the purpose of this fork?
There was a problem hiding this comment.
Yeah that sounds like a good idea. Or just a more high up
|
Cc: @ripienaar would love your review on this. |
|
Random thought, it's been a while.. but if I remember correctly, the only reason this fork exists is because of this: If there are no other changes (this needs to be confirmed).. I wonder if there's a better way to maintain this delta.. or if someone wants to champion it getting added upstream. |
|
I see #2 got merged in My root problem seems to have been addressed 3 years ago to a branch of this repository (this explain why this is so "deja vu" for me) in #1 😄 So as far as I am concerned, being able to switch to upsteam would be great. mitchellh#23 report merge conflicts. Fixing them and adding some context to explain how to reproduce the issue being fixed might help? |
|
Just realized I never merged this. Merging now, to avoid blocking anything. Let me know if there are any follow up prs related to this. |
The upstream project has some commits missing from this fork. Syncing this
copy will fix the build of downstream projects relying on this fork instead of
upstream, e.g. choria which currently breaks on i386 because of the lack of
32d7659.