Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeList.txt: fixed inconsistent lib name in .pc #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MartinPulec
Copy link

Hi, I am proposing following patch to CMakeLists.txt. Basically, in Linux/mac, the generated pkg-config file contains wrong library name because of the following line in CMakeLists.txt:

set_target_properties(CFHDCodecStatic PROPERTIES OUTPUT_NAME CFHDCodec)

Because of that, without the patch, the output libcineformsdk.pc file contains -lCFHDCodecStatic while the actual library built is libCFHDCodec.a because the substituted name in pc file is the name of the target, not its OUTPUT_NAME property.

Inconsistent library name `CFHDCodecStatic` was output to pkg-config
file (libcineformsdk.pc) while the actual library created on *nix
systems is libCFHDCodec.a (similarly for shared build). This is because
the target name was put into the .pc file instead of its OUTPUT_NAME
property (if defined).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant