Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

A bit of cleanup and make ngrok work out of the box #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mimming
Copy link
Contributor

@mimming mimming commented Nov 13, 2013

  • Changed drill icon to white on transparent to match UI guidelines
  • Removed unused assets
  • Added ngrok exception to the URL builder so that it will work without code changes (since we're recommending it pretty often these days)

…ded ngrok exception to the URL builder so that it will work without code changes (since we're recommending it pretty often these days), removed unused assets
@ghchinoy
Copy link
Contributor

lgtm 👍

GenericUrl url = new GenericUrl(req.getRequestURL().toString());
url.setRawPath(relativePath);
// If you're using a request forwarder, like ngrok, you probably need to
// change this function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this comment supposed to mean? Which function should the developer change?

Nit: period at the end of the comment.

@saifrahmed
Copy link

BTW, who at Google wrote this documentation page? I was cracking up
laughing to the point my family and cat were looking at strange:

Straight from the Google Glass API Documentation Page (
https://developers.google.com/glass/stories):

"Each step in human technological advancement provides improved methods for
the distribution of cat photos. Project Glass is no different.
Since every photograph is better with a cat, this service allows users to
composite a random cat image and a photograph that they've taken with
Glass."

On Tue, Nov 12, 2013 at 9:52 PM, Jenny Murphy [email protected]:

  • Changed drill icon to white on transparent to match UI guidelines
  • Removed unused assets
  • Added ngrok exception to the URL builder so that it will work
    without code changes (since we're recommending it pretty often these days)

You can merge this Pull Request by running

git pull https://github.com/googleglass/mirror-quickstart-java ngrok-and-images

Or view, comment on, or merge it at:

#17
Commit Summary

  • Changed drill icon to white on transparent to match UI guidelines,
    added ngrok exception to the URL builder so that it will work without code
    changes (since we're recommending it pretty often these days), removed
    unused assets

File Changes

Patch Links:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants