Add test for out-of-script characters in sample texts #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoncozens
force-pushed
the
test-out-of-script
branch
from
205f043
to
15819be
Compare
|
ykg_Cyrl.textproto should use U+051D CYRILLIC SMALL LETTER WE instead of U+0077 LATIN SMALL LETTER W. ady_Cyrl.textproto should use U+04C0 CYRILLIC LETTER PALOCHKA and/or U+04CF CYRILLIC SMALL LETTER PALOCHKA instead of U+0049 LATIN CAPITAL LETTER I and U+0069 LATIN SMALL LETTER I. |
moyogo
added a commit
to moyogo/googlefonts-lang
that referenced
this pull request
Sep 29, 2023
moyogo
added a commit
that referenced
this pull request
Oct 29, 2023
…e they use Greek characters
simoncozens
force-pushed
the
test-out-of-script
branch
from
4d2227b
to
1bc8ff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One common cause of tofu is when we have a sample text which purports to be in one script ("Syloti Nagri", let's say) but which actually contains some characters from another script ("Bengali"). As well as tofu it's also a warning that something has gone wrong with the sample text ("𐐹𐐲𐑊𐐮𐐻𐐮𐐿𐐲𐑊, jurisdictional 𐐲𐑉 𐐮𐑌𐐻𐐲𐑉𐑌𐐰𐑇𐐲𐑌𐐲𐑊")
This test will currently fail because we have some bad sample texts...