-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IFT] Implement support for parsing and applying Table Keyed patches #1179
Conversation
e7e1f7d
to
f947f8a
Compare
0b41aca
to
1732771
Compare
4be7dc1
to
6826ca9
Compare
2cd2529
to
72281f6
Compare
29320e1
to
0f6f2df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay a bunch of little observations mostly around the API, but overall this looks reasonable to me.
Use this instead of raw arrays in the read-fonts/write-fonts IFT impl.
This new setup hides some of the details like compatibility ID and encoding format. Now a PatchUri (from the patch map) is used to produce a patch object which can be applied directly to an appropriate base.
09c5989
to
b18cd41
Compare
7dce5bc
to
505f7b1
Compare
let Some(stream_length) = next_offset | ||
.checked_sub(offset) | ||
.and_then(|v| v.checked_sub(STREAM_START)) | ||
// brotli stream starts at the (u32 tag + u8 flags + u32 length) = 9th byte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment is now in the wrong place I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
505f7b1
to
f831bd0
Compare
Specification: https://w3c.github.io/IFT/Overview.html#table-keyed