[IFT] Implement support for parsing and applying Table Keyed patches #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garretrieger
force-pushed
the
ift_patches
branch
from
e7e1f7d
to
f947f8a
Compare
garretrieger
force-pushed
the
ift_patches
branch
from
0b41aca
to
1732771
Compare
garretrieger
force-pushed
the
ift_patches
branch
from
4be7dc1
to
6826ca9
Compare
garretrieger
force-pushed
the
ift_patches
branch
from
2cd2529
to
72281f6
Compare
garretrieger
force-pushed
the
ift_patches
branch
from
29320e1
to
0f6f2df
Compare
cmyr
approved these changes
Oct 7, 2024
Use this instead of raw arrays in the read-fonts/write-fonts IFT impl.
This new setup hides some of the details like compatibility ID and encoding format. Now a PatchUri (from the patch map) is used to produce a patch object which can be applied directly to an appropriate base.
garretrieger
force-pushed
the
ift_patches
branch
from
09c5989
to
b18cd41
Compare
garretrieger
force-pushed
the
ift_patches
branch
3 times, most recently
from
7dce5bc
to
505f7b1
Compare
cmyr
reviewed
Oct 7, 2024
| let Some(stream_length) = next_offset | ||
| .checked_sub(offset) | ||
| .and_then(|v| v.checked_sub(STREAM_START)) | ||
| // brotli stream starts at the (u32 tag + u8 flags + u32 length) = 9th byte |
There was a problem hiding this comment.
this comment is now in the wrong place I think?
garretrieger
force-pushed
the
ift_patches
branch
from
505f7b1
to
f831bd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification: https://w3c.github.io/IFT/Overview.html#table-keyed