[skrifa] autohint: CJK edge hinting #1138
Conversation
This was similar enough to latin that changes were folded into the current code with some branches.
Completes the CJK hinting algorithm
| GlyphId::new(9), | ||
| &style::STYLE_CLASSES[style::StyleClass::HANI], | ||
| ); | ||
| let expected_coords = [ |
There was a problem hiding this comment.
might be useful to just note where these came from..
There was a problem hiding this comment.
Noted that these are generated with some lovely printf debugging in FreeType
| let edge2_ix = edge.link_ix.map(|x| x as usize); | ||
| let edge2 = edge2_ix.map(|ix| &edges[ix]); | ||
| // If we have two neutral zones, skip one of them. | ||
| if let (true, Some(edge2)) = (edge.blue_edge.is_some(), edge2) { |
There was a problem hiding this comment.
can't believe we still don't have if-let chains!? but apparently not (rust-lang/rust#53667)
(if we did, this could be,
if let Some(edge2) = edge2 && edge.blue_edge.is_some() { .. })
There was a problem hiding this comment.
This seems to always be just over the horizon... at least we can avoid the double if with the tuple pattern matching so I don't want to complain too much
| // 1px < width < 1.5px | ||
| (38, 26) | ||
| }; | ||
| if cur_len < 96 { |
note where our expected values come from
Agreed. I filed #1141 to clean all of this up after we ensure matching behavior. |
Completes the CJK hinting algorithm
Based on #1134