Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[klippa] subset name table #1133

Merged
merged 2 commits into from
Sep 5, 2024
Merged

[klippa] subset name table #1133

merged 2 commits into from
Sep 5, 2024

Conversation

qxliu76
Copy link
Contributor

@qxliu76 qxliu76 commented Sep 4, 2024 •
edited
Loading

TODO:

  1. as Colin suggested, use something similar to BEBuffer for serialization.
  2. use Subset trait

rsheeter
rsheeter reviewed Sep 5, 2024
View reviewed changes
klippa/src/name.rs Outdated Show resolved Hide resolved
@rsheeter
Copy link
Collaborator

rsheeter commented Sep 5, 2024

Please document where your test files came from in https://github.com/googlefonts/fontations/tree/main/font-test-data/test_data#test-font-sources to make #1127 as easy as possible.

rsheeter
rsheeter reviewed Sep 5, 2024
View reviewed changes
klippa/src/name.rs Outdated Show resolved Hide resolved
rsheeter
rsheeter reviewed Sep 5, 2024
View reviewed changes
klippa/src/name.rs Outdated Show resolved Hide resolved
rsheeter
rsheeter approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@rsheeter rsheeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits

@qxliu76 qxliu76 merged commit e5a3a1b into main Sep 5, 2024
10 checks passed
@qxliu76 qxliu76 deleted the name_subset branch September 5, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsheeter rsheeter rsheeter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qxliu76 @rsheeter