Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pubsub): add otel tracing with links #9594

Merged
merged 76 commits into from
Aug 2, 2024
Merged

feat(pubsub): add otel tracing with links #9594

merged 76 commits into from
Aug 2, 2024

Commits on Sep 18, 2023

  1. feat(pubsub): add otel tracing for subscribing

    @hongalex
    hongalex committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    90401ff View commit details
    Browse the repository at this point in the history

  2. sync with main otel trunk

    @hongalex
    hongalex committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    a24c893 View commit details
    Browse the repository at this point in the history

  3. fix trailing merge conflict lines

    @hongalex
    hongalex committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    d307201 View commit details
    Browse the repository at this point in the history

  4. run go mod tidy

    @hongalex
    hongalex committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    c0dfd35 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. add subscribe span test, refactor to map to use SpanContext

    @hongalex
    hongalex committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    603835c View commit details
    Browse the repository at this point in the history

  2. switch to using sync.map for optimization

    @hongalex
    hongalex committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    2b2fc38 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. fix parent spans

    @hongalex
    hongalex committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    da15e9b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. switch subscribe spans to use events

    @hongalex
    hongalex committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    13ad8ea View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. make subscribe span end after ack

    @hongalex
    hongalex committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    2980177 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. use updated custom attribute names

    @hongalex
    hongalex committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    9386954 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. standardize attribute names and span names

    @hongalex
    hongalex committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    29b7888 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. upgrade dependencies, add disable trace flag

    @hongalex
    hongalex committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    9f95507 View commit details
    Browse the repository at this point in the history

  2. clean up create span

    @hongalex
    hongalex committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    718c28a View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. wrap publish side spans in helpers

    @hongalex
    hongalex committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    de24f2f View commit details
    Browse the repository at this point in the history

  2. add test for when telemetry is disabled

    @hongalex
    hongalex committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    3724293 View commit details
    Browse the repository at this point in the history

  3. fix issue with nil clientconfig

    @hongalex
    hongalex committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    28cad4d View commit details
    Browse the repository at this point in the history

  4. add code.Function attribute

    @hongalex
    hongalex committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b4d5173 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. make tracing disabled by default, wrap spans in helper

    @hongalex
    hongalex committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    0164a15 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. span events cleanup

    @hongalex
    hongalex committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    3c35fb0 View commit details
    Browse the repository at this point in the history

  2. merge in changes from main branch

    @hongalex
    hongalex committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    7c045e7 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Merge branch 'main' of github.com:googleapis/google-cloud-go into pub… 

    …sub-otel-trace-receive-clean
    @hongalex
    hongalex committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    8c93af3 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. support context passing for GAPIC spans

    @hongalex
    hongalex committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    f80cc12 View commit details
    Browse the repository at this point in the history

  2. merge with feature trunk

    @hongalex
    hongalex committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    ba6b1e0 View commit details
    Browse the repository at this point in the history

  3. undo changes to semconv in storage client

    @hongalex
    hongalex committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    97e1cef View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. fix publish tests and parent ordering

    @hongalex
    hongalex committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    ef00726 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'pubsub-otel-trace-receive-clean' of github.com:hongalex… 

    …/google-cloud-go into pubsub-otel-trace-receive-clean
    @hongalex
    hongalex committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    cadb30c View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. fix disable tracing and error tests

    @hongalex
    hongalex committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    45641de View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. update subscribe side spans and tests

    @hongalex
    hongalex committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    8a2cd61 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. fix race condition, rename concurrency control span

    @hongalex
    hongalex committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    2800def View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. add basic benchmark

    @hongalex
    hongalex committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    3d6b2f2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'pubsub-otel-trace-receive-clean' of github.com:hongalex… 

    …/google-cloud-go into pubsub-otel-trace-receive-clean
    @hongalex
    hongalex committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    2fedef2 View commit details
    Browse the repository at this point in the history

  3. make process span end after ack/nack called

    @hongalex
    hongalex committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    04d5233 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. merge main

    @hongalex
    hongalex committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    af71630 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'pubsub-otel-trace-receive-clean' of github.com:hongalex… 

    …/google-cloud-go into pubsub-otel-trace-beta
    @hongalex
    hongalex committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    219d93b View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. sync with trunk branch

    @hongalex
    hongalex committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b553856 View commit details
    Browse the repository at this point in the history

  2. run go mod tidy

    @hongalex
    hongalex committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    06adcf7 View commit details
    Browse the repository at this point in the history

  3. switch to using exp/slices since go1.21 not supported yet

    @hongalex
    hongalex committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    763a44e View commit details
    Browse the repository at this point in the history

  4. update activeSpans sync.map comment and name

    @hongalex
    hongalex committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    592b1f6 View commit details
    Browse the repository at this point in the history

  5. add helper function for extracting resource ID from fqn

    @hongalex
    hongalex committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    78b2dc4 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. guard otel code behind flag

    @hongalex
    hongalex committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1d81a00 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. switch code.function naming

    @hongalex
    hongalex committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    47be12a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:googleapis/google-cloud-go into pub… 

    …sub-otel-trace-links
    @hongalex
    hongalex committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    dfd4dfa View commit details
    Browse the repository at this point in the history

  3. Merge branch 'pubsub-otel-trace' of github.com:googleapis/google-clou… 

    …d-go into pubsub-otel-trace-links
    @hongalex
    hongalex committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    2165f3a View commit details
    Browse the repository at this point in the history

  4. remove extra argument from toMessage

    @hongalex
    hongalex committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    306043e View commit details
    Browse the repository at this point in the history

  5. revert changes to ctx passed to fc.acquire, fix span hierarchy

    @hongalex
    hongalex committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    339babb View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. rename span map and fix context clobbering bug

    @hongalex
    hongalex committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    fdf81aa View commit details
    Browse the repository at this point in the history

  2. removed unused args in message conversion helpers

    @hongalex
    hongalex committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    210edcb View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. fix leak in activeSpans map, shift context passing, rename attributes

    @hongalex
    hongalex committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    c3d5c9b View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. fix failing tests because of attributes changes

    @hongalex
    hongalex committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5e17348 View commit details
    Browse the repository at this point in the history

  2. cleanup unused function and rename FQN helper

    @hongalex
    hongalex committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    0b40755 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. simplify payload size attribute calc

    @hongalex
    hongalex committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5589d42 View commit details
    Browse the repository at this point in the history

  2. fix issue with trying to use uninitialized span

    @hongalex
    hongalex committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    bacda49 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. fix merge conflict with main

    @hongalex
    hongalex committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    110fd53 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. bring in changes from diverged otel branch

    @hongalex
    hongalex committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    4b1aa55 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'pubsub-otel-trace-receive-clean' of github.com:hongalex… 

    …/google-cloud-go into pubsub-otel-trace-links
    @hongalex
    hongalex committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    e5c1f6b View commit details
    Browse the repository at this point in the history

  3. run go mod tidy

    @hongalex
    hongalex committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8db922a View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. upgrade to latest semconv version

    @hongalex
    hongalex committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    97bb12d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:googleapis/google-cloud-go into pub… 

    …sub-otel-trace-links
    @hongalex
    hongalex committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    f8291a0 View commit details
    Browse the repository at this point in the history

  3. migrate more attributes to semconv 1.26.0

    @hongalex
    hongalex committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    e62f21e View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. fix trace tests

    @hongalex
    hongalex committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    f160c6a View commit details
    Browse the repository at this point in the history

  2. add ink to batch spans for message spans

    @hongalex
    hongalex committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    a6b724a View commit details
    Browse the repository at this point in the history

  3. add name of span we are linking to

    @hongalex
    hongalex committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    249e8ce View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. add project attribute, check span recording

    @hongalex
    hongalex committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b77a0f5 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. fix issue with not pulling messages 

    revert lang version changes to go.mod/work

revert changes to go.mod

fix go otel dependency versions

remove unneeded changes

revert renaming of ctx

add clarifying comment to activeSpans map

run go mod tidy

commit go.sum

run go mod tidy
    @hongalex
    hongalex committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    454e69e View commit details
    Browse the repository at this point in the history

  2. resolve merge

    @hongalex
    hongalex committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3179843 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. run go.mod tidy

    @hongalex
    hongalex committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    2962ed2 View commit details
    Browse the repository at this point in the history

  2. temporarily remove use of go1.21 package

    @hongalex
    hongalex committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b432d07 View commit details
    Browse the repository at this point in the history

  3. remove use of attribute.Set which requires go1.21

    @hongalex
    hongalex committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    41e3750 View commit details
    Browse the repository at this point in the history

  4. downgrade back to go1.20

    @hongalex
    hongalex committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    0fca05b View commit details
    Browse the repository at this point in the history

  5. downgrade back to go1.20

    @hongalex
    hongalex committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e43571c View commit details
    Browse the repository at this point in the history

  6. bump go version to use latest otel version

    @hongalex
    hongalex committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b32bde9 View commit details
    Browse the repository at this point in the history

  7. update enable otel client comment

    @hongalex
    hongalex committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    13ee471 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. improve documentation, fix ack/modack logic flow

    @hongalex
    hongalex committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    980603f View commit details
    Browse the repository at this point in the history

  2. clarified context assignment comment for otelctx

    @hongalex
    hongalex committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    be8f7fb View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. fix span context propagation in subscribe spans

    @hongalex
    hongalex committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    84aefe9 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. undo bad merge, fix empty project FQN parsing

    @hongalex
    hongalex committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    6475a66 View commit details
    Browse the repository at this point in the history