chore(storage): fix ReadStallTimeout test #10992
Merged
+46
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix this test to work in the CI. Also remove a spurious log statement.
product-auto-label
bot
added
the
api: storage
raj-prince
reviewed
Oct 17, 2024
storage/client_test.go
Outdated
| } | ||
| defer r.Close() | ||
| // Plant stall at start for 1s. | ||
| instructions := map[string][]string{"storage.objects.get": {"stall-for-1s-after-0K"}} |
There was a problem hiding this comment.
We should set the delay to longer than 5 seconds. If a retry occurs, the process will work as expected; otherwise, it will fail with a deadline exceeded error.
Also, I have fixed a bug in the storage-test-bench. We need to take this change before this PR. P
Storage-test-bench fix: googleapis/storage-testbench#690
There was a problem hiding this comment.
Good catch. I released a new emulator version and updated the test to have a longer stall.
raj-prince
approved these changes
Oct 17, 2024
frankyn
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this test to use the emulator test harness so it will run in the presubmit emulator run and not with the integration tests. Also reduce timings for quicker execution.