Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): add opentelemetry tracing support #10709

Merged
merged 6 commits into from
Aug 19, 2024

Conversation

hongalex
Copy link
Member

This PR merges changes two other reviewed PRS: in #8317 and #9594, which merged changes into a feature branch pubsub-otel-trace.

Specifically this includes

  • Tracing support for publishing and subscribing
  • context propagation between publisher and subscriber via Pub/Sub message attributes
  • Linking for batch RPC spans (publish, ack, nack/modack)
  • New setting EnableOpenTelemetryTracing to pass into NewClientWithConfig to enable tracing

NOTE: OpenTelemetry tracing standards are in active development, and thus attributes, links, and span names are EXPERIMENTAL and subject to change or removal without notice.

@hongalex hongalex requested review from shollyman and a team as code owners August 19, 2024 21:46
Copy link

conventional-commit-lint-gcf bot commented Aug 19, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Aug 19, 2024
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only scrutinized this superficially, given the nature of the change.

@hongalex hongalex merged commit bbd3366 into googleapis:main Aug 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants