Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(spanner): add json handling in executor #10327

Merged
merged 4 commits into from
Jun 6, 2024
Merged

chore(spanner): add json handling in executor #10327

merged 4 commits into from
Jun 6, 2024

Conversation

harshachinta
Copy link
Contributor

@harshachinta harshachinta commented Jun 5, 2024 •
edited
Loading

The changes from #10297 are added in this PR.
Add the following handling in JSON executor code,

  1. Treat number as number instead of float64 during JSON marshalling (both encoding and decoding).
  2. Override default html escape since the systest expect that output.

fixed b/343096930

@harshachinta harshachinta requested review from a team as code owners June 5, 2024 15:29
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jun 5, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2024
@harshachinta harshachinta enabled auto-merge (squash) June 6, 2024 14:37
@harshachinta harshachinta merged commit 52e7ade into googleapis:main Jun 6, 2024
8 checks passed
@harshachinta harshachinta mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshachinta @rahul2393 @kokoro-team