ci: Remove unused values from release scripts #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanda-tarafa
added
the
do not merge
jskeet
approved these changes
Oct 4, 2024
Yes, those assumptions are correct. |
olavloite
approved these changes
Oct 4, 2024
amanda-tarafa
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@olavloite I've removed from these scripts some values that you are not using, because you are not publishing docs with docuploader nor running integration tests on release. Can you please confirm all of that? Removing these makes migration easier.
@jskeet Equally, take a look and see if something seems not right. These scripts are originally copied from google-cloud-dotnet but we have diverged over time.
Marking as
do not mergeas I need to coordinate merging of this PR with some CLs. See b/371220760 for more information.