Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example section for HmacSecretKey class #103

Merged
merged 2 commits into from
May 6, 2024

Conversation

HamdaanAliQuatil
Copy link
Collaborator

  • Added Examples section for the HmacSecretKey class in the API Reference Docs
  • Made the sample code self-contained which one could copy and run.

Here's the self-contained code and the terminal logs: https://gist.github.com/HamdaanAliQuatil/bd32945af3091ff7ba72071386ff4de7

@HamdaanAliQuatil
Copy link
Collaborator Author

Takes a step towards #101

lib/src/webcrypto/webcrypto.hmac.dart Outdated Show resolved Hide resolved
lib/src/webcrypto/webcrypto.hmac.dart Outdated Show resolved Hide resolved
lib/src/webcrypto/webcrypto.hmac.dart Outdated Show resolved Hide resolved
@jonasfj
Copy link
Member

jonasfj commented May 6, 2024

The comment about length is a little confusing. The rest looks fine, my comments are just nits :)

@jonasfj jonasfj merged commit 232f5d6 into google:master May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants