Skip to content

Commit

Permalink
Manually specify firefox location for package:test on macos
Browse files Browse the repository at this point in the history
  • Loading branch information
jonasfj authored Oct 22, 2024
1 parent 8583352 commit 37f65ff
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ jobs:
run: |
flutter config --no-analytics
- run: flutter pub get
#- run: flutter pub run webcrypto:setup
#- run: flutter test
#- run: flutter test --platform chrome
#- run: flutter test integration_test/webcrypto_test.dart -d macos
# working-directory: ./example
- run: flutter pub run webcrypto:setup
- run: flutter test
- run: flutter test --platform chrome
- run: flutter test integration_test/webcrypto_test.dart -d macos
working-directory: ./example
# TODO: Enable chromdriver testing on MacOS when it works reliably
#- uses: nanasess/setup-chromedriver@v2
#- name: Run integration_test with chromedriver
Expand All @@ -78,8 +78,13 @@ jobs:
# --target=integration_test/webcrypto_test.dart \
# -d chrome
- uses: browser-actions/setup-firefox@v1
- run: bash -c 'which firefox'
- run: flutter pub run test -p firefox #vm,chrome # TODO: Enable firefox if it works
- name: flutter pub run test -p vm,chrome,firefox
shell: bash
# Remove FIREFOX_EXECUTABLE override when flutter upgrades past package:test 1.25.8
# Issue is fixed in https://github.com/dart-lang/test/pull/2276
run: |
export FIREFOX_EXECUTABLE="$(which firefox)"
flutter pub run test -p vm,chrome,firefox
windows:
name: webcrypto on Windows desktop / Chrome / Firefox
runs-on: windows-latest
Expand Down

0 comments on commit 37f65ff

Please sign in to comment.