Skip to content

Commit

Permalink
Test with firefox on macos again (#163)
Browse files Browse the repository at this point in the history
* Try to find where firefox is installed

* Update test.yml

* Manually specify firefox location for package:test on macos
  • Loading branch information
jonasfj authored Oct 23, 2024
1 parent c1ca4f4 commit 1013ffb
Showing 1 changed file with 16 additions and 4 deletions.
20 changes: 16 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,14 @@ jobs:
# --driver=test_driver/integration_test.dart \
# --target=integration_test/webcrypto_test.dart \
# -d chrome
# TODO: Enable firefox testing on MacOS when it works
- run: flutter pub run test -p vm,chrome
- uses: browser-actions/setup-firefox@v1
- name: flutter pub run test -p vm,chrome,firefox
shell: bash
# Remove FIREFOX_EXECUTABLE override when flutter upgrades past package:test 1.25.8
# Issue is fixed in https://github.com/dart-lang/test/pull/2276
run: |
export FIREFOX_EXECUTABLE="$(which firefox)"
flutter pub run test -p vm,chrome,firefox
macos-15:
name: webcrypto on macOS 15 desktop / Chrome
runs-on: macos-15 # Test with xcode 16
Expand All @@ -98,8 +104,14 @@ jobs:
- run: flutter test integration_test/webcrypto_test.dart -d macos
working-directory: ./example
# TODO: Enable chromedriver testing on MacOS when it works reliably
# TODO: Enable firefox testing on MacOS when it works
- run: flutter pub run test -p vm,chrome
- uses: browser-actions/setup-firefox@v1
- name: flutter pub run test -p vm,chrome,firefox
shell: bash
# Remove FIREFOX_EXECUTABLE override when flutter upgrades past package:test 1.25.8
# Issue is fixed in https://github.com/dart-lang/test/pull/2276
run: |
export FIREFOX_EXECUTABLE="$(which firefox)"
flutter pub run test -p vm,chrome,firefox
windows:
name: webcrypto on Windows desktop / Chrome / Firefox
runs-on: windows-latest
Expand Down

0 comments on commit 1013ffb

Please sign in to comment.