Skip to content

Commit

Permalink
Revert "pw_system: Don't use implementation_deps"
Browse files Browse the repository at this point in the history
This reverts commit 65c5625.

Reason for revert: Implementation deps now supported internally.

Original change's description:
> pw_system: Don't use implementation_deps
>
> This is just a temporary mitigation for a lack of support for
> implementation_deps internally. I hope to revert this within weeks.
>
> Bug: 304374970
> Bug: 356667663
> Change-Id: I16cc22c36960cb53676591709f5402f2a8032370
> Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/226977
> Pigweed-Auto-Submit: Ted Pudlik <[email protected]>
> Lint: Lint 🤖 <[email protected]>
> Commit-Queue: Auto-Submit <[email protected]>
> Reviewed-by: Armando Montanez <[email protected]>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 304374970
Bug: 356667663
Change-Id: Ie51d90b1e29a8244bd60390e8fb5e6fb52e84e8c
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/227601
Reviewed-by: Armando Montanez <[email protected]>
Presubmit-Verified: CQ Bot Account <[email protected]>
Commit-Queue: Ted Pudlik <[email protected]>
Lint: Lint 🤖 <[email protected]>
  • Loading branch information
tpudlik authored and CQ Bot Account committed Oct 7, 2024
1 parent 35c10c4 commit 29fc404
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions pw_system/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -562,8 +562,7 @@ cc_library(
"threads.cc",
],
hdrs = ["public/pw_system/system.h"],
includes = ["public"],
deps = [
implementation_deps = [
":async_packet_io",
":device_service",
":file_manager",
Expand All @@ -572,16 +571,12 @@ cc_library(
":thread_snapshot_service",
":transfer_service",
":work_queue",
"//pw_allocator:allocator",
"//pw_allocator:best_fit_block_allocator",
"//pw_allocator:synchronized_allocator",
"//pw_async2:allocate_task",
"//pw_async2:dispatcher",
"//pw_async2:pend_func_task",
"//pw_channel",
"//pw_hdlc:router",
"//pw_multibuf:simple_allocator",
"//pw_rpc",
"//pw_rpc/pwpb:echo_service",
"//pw_sync:interrupt_spin_lock",
"//pw_thread:thread",
Expand All @@ -592,6 +587,13 @@ cc_library(
],
"//conditions:default": [],
}),
includes = ["public"],
deps = [
"//pw_allocator:allocator",
"//pw_async2:dispatcher",
"//pw_channel",
"//pw_rpc",
],
)

cc_library(
Expand Down

0 comments on commit 29fc404

Please sign in to comment.