Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate pomxml extractor which also performs transitive dependency resolution #1331

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

another-rex
Copy link
Collaborator

@another-rex another-rex commented Oct 18, 2024

Part of #1330

No functional change is made compared to the version in internal/manifest, just switched to use the osv-scalibr interface.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 77.57009% with 24 lines in your changes missing coverage. Please review.

Project coverage is 68.12%. Comparing base (a7d6524) to head (a82f695).

Files with missing lines Patch % Lines
...ckfilescalibr/language/java/pomxmlnet/extractor.go 77.57% 21 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1331      +/-   ##
==========================================
+ Coverage   68.05%   68.12%   +0.07%     
==========================================
  Files         183      184       +1     
  Lines       17498    17605     +107     
==========================================
+ Hits        11908    11994      +86     
- Misses       4949     4968      +19     
- Partials      641      643       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuixq
Copy link
Contributor

cuixq commented Oct 18, 2024

There is a PR about Maven registry support #1286, I would recommend to merge this PR afterwards (refactoring is needed I think).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants